Repository navigation
fix(docs): calm the landing cards, tidy the switches and list, and show a package's examples in its sidebar - #107
Conversation
…ow a package's examples in its sidebar - Card loops never blank a card: annotate marks redraw one at a time, and github, chips, and icon cards nudge their icons instead of hiding content. - The include card wraps its code, and the live-code embed still keeps 16:9. - Segmented switches are one soft track with a raised thumb; the package list drops its copy button. - The playground preview's /style.css is served by the Nuxt build, so the preview has its font again; Extra CSS folds until it has CSS. - A package's sidebar folds its playground examples as preview cards instead of one Open in playground link. - The headline names Comark plugins, the hero copy is shorter, and the READMEs say the project is independent of Comark.
Latest result Pull request merged. Final answersSession Pull request merged. Session Waiting for GitHub merge request 77283bb4-b2ce-4ee9-b93e-79f5ab051fb4. Current HEAD matches the expected commit and all required checks pass. Pullfrog findings are addressed: P1 thumbnail styles, P1 root route, P1 package-card locator, P2 disclosure state, and P2 sidebar width. Threads are resolved; the cancelled older e2e run is superseded by the successful current check. Session Push window closed: 11 repair pushes in the last 24 hours. Required checks fail, so the next repair push and pass start at 2026-10-23T22:01:34.566Z. A person's comment or review or a merge conflict still starts a pass. Session Push window closed: 11 repair pushes in the last 24 hours. Required checks fail, so the next repair push and pass start at 2026-10-23T22:01:34.566Z. A person's comment or review or a merge conflict still starts a pass. Session Push window closed: 11 repair pushes in the last 24 hours. Required checks fail, so the next repair push and pass start at 2026-10-23T22:01:34.566Z. A person's comment or review or a merge conflict still starts a pass. Session Push window closed: 11 repair pushes in the last 24 hours. Required checks fail, so the next repair push and pass start at 2026-10-23T22:01:34.566Z. A person's comment or review or a merge conflict still starts a pass. Session Push window closed: 11 repair pushes in the last 24 hours. Required checks fail, so the next repair push and pass start at 2026-10-23T22:01:34.566Z. A person's comment or review or a merge conflict still starts a pass. Session Push window closed: 11 repair pushes in the last 24 hours. Required checks fail, so the next repair push and pass start at 2026-10-23T22:01:34.566Z. A person's comment or review or a merge conflict still starts a pass. Session Push window closed: 11 repair pushes in the last 24 hours. Required checks fail, so the next repair push and pass start at 2026-10-23T22:01:34.566Z. A person's comment or review or a merge conflict still starts a pass. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
View all previews: View all previews ↗ |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
The new package Examples sidebar cards do not get the wider sidebar this PR intends, so this layout fix needs one selector adjustment before merging.
Reviewed changes
This review covers the generated docs/sidebar markup, playground asset and theme changes, landing-page presentation, README updates, and the focused e2e test in 285b3a1.
- Generated sidebar examples — Adds folded, package-specific playground preset cards and updates the sidebar navigation behavior.
- Playground build/runtime — Copies
style.cssinto the generated public assets and opens the Extra CSS disclosure when a theme contains CSS. - Landing presentation — Revises package cards, segmented controls, animations, and embed/include sizing.
- Verification/docs — Updates the playground e2e scenario and project README wording.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This incremental review covers the follow-up sidebar-width fix and its updated end-to-end coverage since the prior Pullfrog review.
- Matched the package sidebar selector — Changed the width rule to match
.presetsnested under.pages-foot, so package Examples cards receive the intended wider sidebar. - Updated the sidebar e2e scenario — Verified that package Examples unfold and that a selected example opens in the playground.
The prior sidebar-width finding is addressed, and pnpm docs:build passes.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
Important
The package-specific Examples cards can render without the plugin styles that define their thumbnails, and the Extra CSS disclosure does not re-fold after switching back to a preset with no custom CSS.
Reviewed changes
This incremental review covers the current head after the prior sidebar-width fix, including the generated package Examples cards, landing-page presentation changes, playground theme disclosure and asset publishing, and updated end-to-end coverage.
- Refactored package examples — Reused the playground preset-card markup for folded package sidebar examples and linked each card to its matching playground preset.
- Reworked landing presentation — Replaced package-card copy controls, adjusted segmented switches, calmed demo animations, and fixed include and embed sizing.
- Updated playground delivery — Added generated
style.cssand changed Extra CSS into a disclosure that opens when a theme includes custom CSS. - Adjusted verification and copy — Updated the docs and playground e2e scenarios and clarified the project README attribution.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This incremental review covers the new thumbnail-style inclusion and Extra CSS disclosure synchronization added since the prior Pullfrog review.
- Styled package thumbnails — Included the collected plugin styles in package documentation pages so the new Examples cards render with the same component styling as the playground.
- Synchronized Extra CSS disclosure — Made theme changes both open and close the disclosure according to whether the selected theme has custom CSS.
- Verification —
pnpm docs:buildpasses at the current head; the focused Playwright coverage remains unrun locally because Chromium is not installed.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This incremental review covers the commits since the prior Pullfrog review: the formatted package-page head assignment and the end-to-end static server's support for both Nitro output layouts.
- Formatted package head handling — Reformatted the existing
pageHeadassignment without changing its behavior. - Supported both Nitro output roots — Updated the e2e server to try
docs/dist/publicanddocs/dist, matching the generated layouts used by different Nuxt versions.
The prior findings remain addressed. pnpm exec tsc --noEmit could not run because the workspace prepare step is blocked by the read-only .git/config; the focused Playwright suite remains unrun locally because Chromium is not installed.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This incremental review covers the e2e static server's support for Nitro's additional .output/public layout and extensionless route files since the prior Pullfrog review.
- Expanded static output discovery — Tries the additional Nitro public root and both directory-index and
.htmlroute layouts without changing the existing generated-site behavior. - Retained request isolation — Confirmed the decoded and normalized request paths remain rooted under the selected static output directories.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This incremental review covers the e2e static-server changes since the prior Pullfrog review.
- Expanded Nitro root discovery — Updated the test server to try the additional
dist/.output/publiclayout alongside the existing public and direct output roots. - Supported extensionless route files — Added
.htmlfallback lookup for non-directory routes while preserving directoryindex.htmlhandling.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This incremental review covers the trailing-slash route fallback added to the e2e static server since the prior Pullfrog review.
- Covered sibling HTML routes — Added a
/<route>.htmllookup alongside/route/index.htmlwhen a request ends in/, matching the supported Nitro output layouts without changing existing route or asset handling.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
Important
The current e2e check fails on the package-card assertion introduced in this delta.
Reviewed changes
This incremental review covers the prepared merge-resolution changes since the prior Pullfrog review, including the landing-card e2e locator update and the static-server merge delta.
- Updated landing-card coverage — Replaced the install-copy assertion with a docs-link and no-copy-control assertion.
- Retained static-output compatibility — Kept the e2e server's support for Nitro roots and extensionless route layouts.
- Merged current package changes — Integrated the latest
mainchanges without introducing a new server path-resolution issue.
gpt-5.6-sol ｜ 𝕏
![vitehub-bot[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
There was a problem hiding this comment.
Important
The latest static-server normalization breaks the root route, so the e2e server returns 404 for / instead of serving the generated homepage.
Reviewed changes
This incremental review covers the static-server path normalization added since the prior Pullfrog review.
- Normalized static route paths — Stripped leading separators before trying Nitro roots and extensionless route layouts.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This incremental review covers the root-route handling and landing package-card locator changes added since the prior Pullfrog review.
- Restored the e2e homepage route — Added an explicit
index.htmlcandidate for/while preserving the supported Nitro roots and route layouts. - Aligned the package-card assertion — Updated the e2e locator to use the rendered
githublabel and kept the/github/link check.
pnpm docs:build passes. The focused Playwright test could not run locally because the Chromium executable is not installed.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This incremental review covers the package Examples end-to-end selector change since the prior Pullfrog review.
- Targeted the generated disclosure — Changed the test to click the emitted
summary.pages-playelement directly, preserving the navigation and selected-page assertions.
gpt-5.6-sol ｜ 𝕏
comark-annotate
comark-badge
comark-cards
comark-carousel
comark-charts
comark-chips
comark-code
comark-deflist
comark-details
comark-diff
comark-embed
comark-fields
comark-figure
comark-file-tree
comark-github
comark-icon
comark-include
comark-linter
comark-mark
comark-media
comark-outline
comark-qr
comark-reading-time
comark-steps
comark-tabs
comark-zoom
commit: |
There was a problem hiding this comment.
ℹ️ No critical issues — one edge-case suggestion inline.
Reviewed changes
This incremental review covers the merge of main since the prior Pullfrog review, including the updated media thumbnail replacement and the current docs build/e2e inputs.
- Handled current media markup — Updated generated thumbnails and demo cards for the current styled media renderer output.
- Integrated current package changes — Included the
figurepackage registration and current docs-facing plugin updates frommain. - Rechecked prior fixes — Confirmed the sidebar Examples selector, static-server root handling, and Examples disclosure test remain addressed.
Note: 1 inline comment(s) dropped because they did not anchor to lines inside the PR diff:
docs/build.ts:538(RIGHT) — line 538 (RIGHT) is not inside a diff hunk
gpt-5.6-sol ｜ 𝕏
Fixes from a pass over the landing canvas (#103), the playground, and the sidebar.
Landing cards
demo-popanddemo-riseare gone.Landing page
Playground
/style.css, which the preview document links, so the preview lost its font on every theme preset. The Nuxt build now publishes it withsearch.json.Sidebar
.menu summaryis scoped to.menu > summary, so it no longer styles every<details>in the sidebar.READMEs
pnpm readypasses. The changed e2e test (a package's playground examples unfold…) hasn't run locally. The Open Graph image still has the old headline.