Repository navigation
feat(lint): each diagnostic carries its rule's severity - #280
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Latest result Pull request merged. Final answersSession Pull request merged. Session Waiting for GitHub merge request b6c451c6-3c12-41a4-8841-1a8a86d6476e. Ready: expected HEAD verified, diff and all supplied reviews inspected, with no actionable findings. Hosted checks passed. Focused severity test and lint()/lintFiles()/JSON smoke checks passed; `vp fmt --check packages/lint` and `git diff --check` passed. Full local tests and type-aware lint were blocked by missing workspace build outputs. No repair changes needed. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes in 7c2a59cd, covering the public diagnostic contract and each integration that consumes or serializes it.
- Library diagnostics:
lint()andlintFiles()now enrich every internal finding with the rule catalog'serroror defaultwarnseverity after sorting. - CLI and ESLint boundaries: JSON output includes severity, text output remains unchanged, and the ESLint worker continues omitting a value that ESLint derives from its own rule configuration.
- Documentation and tests: README and getting-started usage document the field, with coverage for core errors, core warnings, package rules, and JSON serialization.
- Verification:
pnpm buildpassed; all 77 focused linter tests passed;vp check packages/lintcompleted with zero errors and one pre-existing warning.
gpt-5.6-sol ｜ 𝕏
comark-annotate
comark-badge
comark-cards
comark-carousel
comark-cast
comark-charts
comark-chat
comark-chips
comark-cjk
comark-code
comark-code-notes
comark-colors
comark-comments
comark-critic
comark-deflist
comark-details
comark-diagrams
comark-diff
comark-embed
comark-fields
comark-figure
comark-file-tree
comark-footnotes
comark-github
comark-icon
comark-include
comark-keys
comark-links
comark-linter
comark-magic-move
comark-mark
comark-mathml
comark-media
comark-metrics
comark-outline
comark-properties
comark-qr
comark-quiz
comark-reading-time
comark-sources
comark-steps
comark-table
comark-tabs
comark-tests
comark-ui
comark-xref
comark-zoom
commit: |
lint()andlintFiles()now returnseverity("error"or"warn") on every diagnostic. It's the same severity Vite Doctor and ESLint report for the rule.Until now a script calling
lint()couldn't tell errors from warnings: the index exports rule titles only. Drop refuses a publish on Comark errors, and has had to copy the error rules by hand and test that the copy matchescomark-linter/doctor's catalog. With this, a caller readsdiagnostic.severity.Finding, private to the package).lint()adds the severity from the catalog when it returns results, so no rule changes.--format jsonoutput now includesseverity. Its text output is unchanged.severityacross, since ESLint takes it from its own config.Checks:
pnpm typecheck,vp lintandvp fmt --checkonpackages/lint, the package's 77 tests (including a new one for a core error, a core warning and a package rule), andpnpm run doctorinpackages/lint.🤖 Generated with Claude Code