Skip to content

test: preserve nested JSON in snapshot privacy checks #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steipete merged 1 commit into from
Oct 23, 2026
Merged

test: preserve nested JSON in snapshot privacy checks #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- Keep the cloud snapshot privacy regression compatible with SQLite 3.53 and 3.54 by explicitly preserving nested JSON arrays across subqueries.

- Update the pinned TruffleHog secret-scanning action to v3.99.3. Thanks @dependabot.
- Request `synchronous=FULL` on every SQLite connection and, on macOS, `fullfsync` for commits and checkpoints. Go test binaries skip the macOS full flush.
- Let the native code producer publish from a captured upstream commit when core progress is fresh, even while provider coverage is incomplete. Retries and coverage are not changed.
Expand Down
2 changes: 1 addition & 1 deletion internal/cli/cloud_snapshot_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ func TestCloudSQLiteSnapshotLegacyPrivacyColumns(t *testing.T) {
create table sync_attempt_failures(error_message text);
insert into sync_attempt_failures values('private');`,
query: `select json_array(
(select json_group_array(raw_json) from comment_revisions),
json((select json_group_array(raw_json) from comment_revisions)),
(select raw_json from pull_request_review_thread_revisions),
(select error_message from sync_attempt_failures))`,
want: `[[null,"",""],"",""]`,
Expand Down
Loading