Repository navigation
test: preserve nested JSON in snapshot privacy checks - #271
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
steipete
added a commit
to openclaw/crawlkit
that referenced
this pull request
Oct 23, 2026
Upgrade modernc.org/sqlite to v1.61.0 and its required libc v1.79.0 so writes waiting on locks respect context cancellation and deadlines. Keep Go 1.27.0 as the minimum and Go 1.27.3 as the build toolchain. Cover the deadline error, bounded wait, absence of an unintended insert, and retry after unlocking. Document explicit JSON conversion across scalar subqueries. Advance the Gitcrawl compatibility pin to the merged openclaw/gitcrawl#271 migration while retaining the published baseline, both full CLI suites, isolation, and integrity checks. Validation: full make check, govulncheck, race tests, 48 release/downstream script tests, both SQLite versions on synthetic queries, independent Codex review through P3, and exact-head CI including the downstream comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cloud snapshot privacy check relied on SQLite preserving a JSON subtype through a scalar subquery. SQLite 3.54.1 quotes that nested array, so the check failed despite unchanged sanitization. Explicitly mark the subquery result with
json(...)and preserve the exact expected array, including nulls and cleared private strings.This unblocks the SQLite lock-cancellation update in openclaw/crawlkit#169 without weakening its pinned downstream compatibility gate. No production query or sanitizer behavior changes.
Validation: reproduced the existing failure with modernc.org/sqlite v1.61.0 (SQLite 3.54.1); all
TestCloudSQLiteSnapshot*tests pass with both v1.60.1 (SQLite 3.53.4) and v1.61.0 using isolated module files. Independent Codex autoreview is clean through P3. CI runs the full repository gates.