Repository navigation
build(deps): refresh tooling and patch source-map-js - #108
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs changes before merge. What this changesThis PR upgrades oxfmt from 0.72.0 to 0.73.0 and locked oxlint from 1.87.0 to 1.88.0. Example: A contributor installs dependencies with the committed lockfile.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Needs changes before merge - 1 item remains This PR updates tooling still older on main; the dependency changes look sound, with one small changelog-policy fix before merge. Priority: P3 Before merge
Findings
Agent review detailsHow this fits togetherThe development toolchain consumes repository files through formatter and linter CLIs and produces formatting and diagnostic results. flowchart LR
A[Package manifest] --> C[pnpm installation]
B[Dependency lockfile] --> C
C --> D[oxfmt and oxlint]
E[Repository files] --> D
D --> F[Formatting and lint results]
Technical reviewBest possible solution: Land the focused tooling upgrade with a short Unreleased changelog entry. Do we have a high-confidence way to reproduce the issue? This is dependency maintenance rather than a bug report; the pinned diff establishes the exact version changes. Is this the best way to solve the issue? Updating the existing dependencies and lockfile is appropriately scoped and preserves the repository's runtime floors, pnpm version, and dependency cooldown. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against eb48e7089aac. Provenance checked
SecurityNone. EvidenceAcceptance criteria:
What I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 15, 2026, 1:29 PM ET / 17:29 UTC. |
Refresh the formatter and linter, align tested dependency ranges, and keep pnpm on the maintained 11.x JavaScript release line. Fix GHSA-68fv-2mgg-jv7q by upgrading the transitive source-map-js dependency to 1.2.2. Add a guarded main-only release dry run so tooling changes can be validated without publication. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
e5b65ac to
42dbdc1
Compare
Update oxfmt to 0.73, oxlint to 1.88, and the maintained pnpm line to 11.28.2. Align the other development dependency ranges with the already-tested lockfile versions, preserving the two-day release cooldown and supported Node.js floors.
A full dependency audit also reproduced GHSA-68fv-2mgg-jv7q in source-map-js 1.2.1 through PostCSS. Refresh that transitive dependency to 1.2.2; the final audit reports no known vulnerabilities.
The release workflow previously supported tag pushes only. Add a main-only manual dry run that validates the current package version and runs the complete release check. Manual runs cannot publish; protected version-tag pushes retain the existing publication path. The package version remains 0.3.9.
Validation:
pnpm install --frozen-lockfile,pnpm run check:release(140 unit tests, nine browser tests, build, format, typecheck, lint and package checks), andpnpm auditpass on a Linux Crabbox lease. Coverage passed (84.84% statements, 85.36% lines). Workflow actionlint and independent P0–P3 autoreview also pass. The lease was stopped after validation.Includes the formatter/linter update from @dependabot[bot].