Repository navigation
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
clawsweeper
Bot
added
clawsweeper:intake:bug
|
Codex review: needs maintainer review before merge. What this changesThis PR verifies FreeBSD Node platform, architecture, major version, and minimum patch level before native builds and tests. Example: The FreeBSD x64 Node 22 job installs Node 22.23.3 against a 22.23.4 matrix floor.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: current main does not verify the installed FreeBSD Node patch level. The focused change has no identified correctness defect, but the four failing FreeBSD checks remain unattributed. Priority: P2 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe reusable native workflow installs Node from FreeBSD pkg, checks its runtime identity, then builds, tests, and packages the native binding; both CI and release prebuilds consume this workflow. flowchart TD
A[CI or release prebuild] --> B[FreeBSD VM]
B --> C[Major-line pkg installation]
C --> D[Runtime identity and version guard]
D --> E[Reject with upgrade guidance]
D --> F[Native build and tests]
F --> G[Binding artifact]
Technical reviewBest possible solution: Keep the focused runtime guard and establish the cause and disposition of the FreeBSD check failures before landing. Do we have a high-confidence way to reproduce the issue? Main's guard has no version comparison, so a FreeBSD runtime with the expected architecture passes regardless of its patch level; this is source-established without executing target code. Is this the best way to solve the issue? The small CLI guard enforces the existing matrix floor at the VM boundary, accepts newer stable versions within the selected major, and leaves package APIs and engines unchanged. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 52244652b89f. Provenance checked
TestingProof path: unit tests only. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 26, 2026, 3:32 AM ET / 07:32 UTC. |
|
Confirmed the runtime-admission failures in run 40285117746: both FreeBSD architectures selected Node 22.23.2 / 24.21.0, below the official 22.23.4 / 24.22.1 floors. The new guard behaves correctly; these are missing patched-runtime qualifications, not flakes to rerun. At head b5d97a4, the local JavaScript check pipeline passed with 108 tests and 14 platform-native skips, and independent P0–P2 review completed without findings. This does not replace FreeBSD native proof. Holding the PR open until patched pkg runtimes or a qualified replacement build route can make all four native jobs pass; no gate was bypassed. |
|
Blocked until the FreeBSD native jobs are green. The guard here is correct: FreeBSD's |
FreeBSD native CI installs major-line
pkgpackages, but its previous guard checked only platform and architecture. An exact patched matrix label therefore did not establish the runtime actually used for native proof.Check the selected executable, stable Node version, platform, architecture and same-major patched floor before native builds/tests. Preserve newer stable patches within the selected major. Refusal records the actual identity and gives package-upgrade guidance. This is CI admission only; package APIs, engines and application runtime policy are unchanged.
Validation:
pnpm checkwith declared pnpm 12.15.0 and patched Node 26.12.1: lint, typecheck, build, 107 tests passed / 15 platform-native skips, package-manifest checks passed. Skips do not establish native behavior..github/actionlint.yaml, shellcheck andgit diff --checkpassed. Initial actionlint omitted the checked-in runner config and reported the existing customxcode-27label; the corrected invocation passed without exceptions.Hosted exact-head result: 20 checks succeeded; all four FreeBSD native jobs stopped at the new runtime admission guard before native build/test. The pkg-selected executable
/usr/local/bin/nodewas 22.23.2 for both Node22 x64/ARM64 jobs (required >=22.23.4 in that major), and 24.21.0 for both Node24 jobs (required >=24.22.1). These are intentional refusals of affected runtimes, not passing native qualification or evidence that the failures are unrelated. Native FreeBSD product execution remains blocked until patched same-major pkg runtimes are available or a separately qualified build route is authorized. No guard, native test or required gate was weakened or skipped.Run: https://github.com/openclaw/proc-safe/actions/runs/40285117746 (failed FreeBSD jobs121446823325,121446823441,121446823431,121446823443). This PR does not establish TLS-mode behavior, release delivery or fleet remediation, and does not publish a release or package.