Repository navigation
build(deps-dev): bump the development group with 3 updates - #43
dependabot[bot] wants to merge 2 commits into
Conversation
Bumps the development group with 3 updates: [oxfmt](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxfmt), [oxlint](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxlint) and [tsdown](https://github.com/rolldown/tsdown). Updates `oxfmt` from 0.70.0 to 0.71.0 - [Release notes](https://github.com/oxc-project/oxc/releases) - [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxfmt/CHANGELOG.md) - [Commits](https://github.com/oxc-project/oxc/commits/oxfmt_v0.71.0/npm/oxfmt) Updates `oxlint` from 1.85.0 to 1.86.0 - [Release notes](https://github.com/oxc-project/oxc/releases) - [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxlint/CHANGELOG.md) - [Commits](https://github.com/oxc-project/oxc/commits/oxlint_v1.86.0/npm/oxlint) Updates `tsdown` from 0.22.14 to 0.23.0 - [Release notes](https://github.com/rolldown/tsdown/releases) - [Commits](rolldown/tsdown@v0.22.14...v0.23.0) --- updated-dependencies: - dependency-name: oxfmt dependency-version: 0.71.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development - dependency-name: oxlint dependency-version: 1.86.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development - dependency-name: tsdown dependency-version: 0.23.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed October 1, 2026, 8:04 AM ET / 12:04 UTC (Revision 2). ClawSweeper reviewWhat this changesUpdates the development formatter, linter, and bundler versions and refreshes their transitive dependencies in the pnpm lockfile. Regression provenancePossible regression — suspected (reviewed change). No predecessor PR is attributed. Merge readiness⛔ Blocked before merge - 3 items remain The updates are still distinct from main, but the bundler upgrade breaks supported Node 25 development installs and contradicts the previously merged compatibility decision. Priority: P2 Review scores
Verification
How this fits togetherThe router package's development tools format and lint source, then build JavaScript and TypeScript declarations. Package validation checks the resulting archive and imports it as a consumer would. flowchart TD
A[Source and package metadata] --> B[Development dependencies]
B --> C[Node engine validation]
C --> D[Format and lint]
C --> E[Build JavaScript and declarations]
E --> F[Package and import validation]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Preserve the established Node 25 installation contract while landing compatible formatter and linter updates. Do we have a high-confidence way to reproduce the issue? Yes, from source: a frozen pnpm install on Node 25 encounters mandatory dependencies whose engine ranges exclude it while engineStrict is enabled. This review did not execute that installation. Is this the best way to solve the issue? No. Retaining the already approved compatible bundler graph is the narrow repair; changing the supported Node range would require a separate explicit compatibility decision. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against cd289d3d3d30. LabelsLabel changes:
Label justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
|
Superseded by #48, which landed the compatible formatter update while retaining the Node 25-compatible tsdown 0.22 graph. Exact-head Node 22/24 CI, Node 25 frozen install/full check/package validation, and ClawSweeper were green. |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Bumps the development group with 3 updates: oxfmt, oxlint and tsdown.
Updates
oxfmtfrom 0.70.0 to 0.71.0Release notes
Sourced from oxfmt's releases.
Commits
2ae2939release(apps): oxlint v1.86.0 && oxfmt v0.71.0 (#27132)f158bffchore(deps): update npm packages (#26865)Updates
oxlintfrom 1.85.0 to 1.86.0Release notes
Sourced from oxlint's releases.
Changelog
Sourced from oxlint's changelog.
... (truncated)
Commits
2ae2939release(apps): oxlint v1.86.0 && oxfmt v0.71.0 (#27132)9d80eedfeat(linter/react/only-export-components): supportallowCompoundComponents...e05b155feat(linter): add typescript/no-generated-empty-object-type (#26958)88a0096chore(oxlint): require tsgolint 7.0.2003 (#27021)Updates
tsdownfrom 0.22.14 to 0.23.0Release notes
Sourced from tsdown's releases.
... (truncated)
Commits
ced9a2cchore: release v0.23.0f5f9ea9docs: add Ember support guide (#1043)8ac89dcchore: upgrade Vitest to v596a4098feat: expose programmatic watch controls (#1062)61718d7chore: upgrade depsd04119cchore: upgrade deps55f89c5chore(deps): update pnpm to v12.1.0 (#1060)946224dfix: ignore optional dependencies in type definitions62f01cdchore: release v0.23.0-rc.1bf53f43fix(cli): camel-case nested flag keysDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions