Repository navigation
build(deps): refresh formatter with Node 25 support - #48
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
/allow-dependencies-change |
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
|
Codex review: needs maintainer review before merge. Reviewed October 1, 2026, 8:11 AM ET / 12:11 UTC. ClawSweeper reviewWhat this changesUpdates the development formatter to oxfmt 0.71 and refreshes its locked dependencies while retaining tsdown 0.22.14. Merge readiness✅ Ready for maintainer review This remains a useful, focused formatter refresh that preserves the established Node-compatible build toolchain. No introduced defect was found, and the change is absent from the reviewed main and latest release. The member-authored PR also requires maintainer handling. Priority: P2 Review scores
Verification
How this fits togetherThe development toolchain formats, builds, and validates this standalone TypeScript router. Its dependency engine requirements determine which supported Node versions contributors can use to install and check the package. flowchart LR
A[Contributor Node version] --> B[Frozen dependency install]
C[Package and lockfile] --> B
B --> D[Engine compatibility checks]
D --> E[Formatter]
D --> F[Existing build toolchain]
E --> G[Package quality checks]
F --> G
Before mergeNone. Agent review detailsSecurityNone. Review metricsNone. Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Technical reviewBest possible solution: Keep the formatter refresh isolated from bundler upgrades so development installs continue to honor the declared Node support range. Do we have a high-confidence way to reproduce the issue? Not applicable to a current-main bug: this PR avoids the incompatible bundler upgrade in the related proposal. The author reports successful frozen installation and full validation on Node 25.9.0. Is this the best way to solve the issue? Yes. Updating only the formatter and its required dependencies is a narrow way to retain the tooling refresh without changing the established bundler or Node support contract. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against cd289d3d3d30. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
What Problem This Solves
Resolves a development-install compatibility problem where the formatter update from #43 also upgraded the bundler to a release that rejects Node 25 under the repository's strict engine checks.
Why This Change Was Made
Updates
oxfmtto 0.71 while retaining the establishedtsdown0.22 dependency graph. This preserves the declared Node support contract and keeps the formatter refresh.User Impact
This affects development tooling only. Contributors can continue using every declared Node version, including Node 25, without frozen-install failures.
Evidence
pnpm install --frozen-lockfilepnpm run checkgit diff --checkSupersedes #43 because its Dependabot branch is not maintainer-editable and the exact-head ClawSweeper review found the Node 25 regression.