Repository navigation
build(deps-dev): bump vitest from 4.1.11 to 5.0.3 - #51
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 4.1.11 to 5.0.3. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.3/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-version: 5.0.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Codex review: blocked before merge. Reviewed October 6, 2026, 5:02 PM ET / 21:02 UTC (Revision 4). ClawSweeper reviewWhat this changesUpdates the development test runner from Vitest 4.1.11 to 5.0.3 and refreshes its locked dependencies. Regression provenancePossible regression — suspected (reviewed change). No predecessor PR is attributed. Merge readiness⛔ Blocked before merge - 3 items remain Keep open with the previously reported compatibility blocker: the unchanged dependency update excludes supported Node 25 development installations. Current main retains Vitest 4, and no merged replacement establishes that this upgrade is already implemented. Priority: P2 Review scores
Verification
How this fits togetherVitest runs UIRouter’s public behavior tests during development and CI. Dependency installation must succeed before those tests and package validation can run. flowchart TD
A[Developer Node version] --> B[Strict dependency installation]
C[Locked test dependencies] --> B
B --> D{Compatible engines}
D -->|Yes| E[Router tests and package checks]
D -->|No| F[Installation blocked]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Retain a test runner compatible with the full supported Node range and preserve strict engine validation, following the existing member decision. Do we have a high-confidence way to reproduce the issue? Yes, source establishes the introduced failure: a normal development install on Node 25 encounters Vitest’s incompatible engine range with engineStrict enabled. Installation was not executed during this read-only review. Is this the best way to solve the issue? No, this upgrade violates the established development compatibility contract; retaining compatible Vitest 4 is the narrowest supported direction. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against f7320e4435a3. LabelsLabel changes:
Label justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (3 earlier review cycles)
|
|
Thanks for the update. Closing this major upgrade because Vitest 5.0.3 excludes Node 25, which remains supported by this repository. A clean install on Node 25.9.0 with our strict engine policy fails with We will retain Vitest 4.1.11; #52 adds the missing Node 25 CI coverage. This upgrade can be reconsidered when the supported development runtime range changes or Vitest restores compatibility. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Update @types/node to 26.6.4 while retaining build and test dependencies that support the declared Node range. tsdown 0.23.0 and Vitest 5.0.3 reject Node 25 under strict engine checks despite passing the previous Node 22/24 matrix. Add Ubuntu Node 25 coverage and document that compatibility boundary. Supersedes the compatible update in #50; #50 and #51 have Node 25 engine blockers. Thanks @dependabot. Validation: Node 25.9.0 / pnpm 11.27.1 full package check, 58 tests, packed-package install/import, strict-engine rejection probes for both held upgrades, workflow YAML parsing, diff check, and independent Codex review. Exact-head CI passed all seven Node/OS jobs, workflow lint, and CodeQL: https://github.com/openclaw/uirouter/actions/runs/37598481727 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps vitest from 4.1.11 to 5.0.3.
Release notes
Sourced from vitest's releases.
... (truncated)
Commits
33cadeachore: release v5.0.3 (#11409)346d389fix(vm): don't reuse scripts across vite environments (#11395)f6c9a49fix(deps): pinwhy-is-node-runningto3.2.1to avoid users running into `...062c75dchore: fix standalone docs build, update exports maps (#11394)caf2887fix(vm): do not optimize deps from index.html (fix #11329) (#11360)50312ebfix(pool): preserve unique pool ids whengroupOrderis set (#11392)7c36748fix(browser): ignore page crash while cancelling (#11386)92ba7fcfix: scope cache key generators to projects (fix #11281) (#11301)38f9885fix(cache): revalidate imports of cached modules (#11381)b24585ffix: don't retry whentest.failsexpectedly failed (#11219)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)