Repository navigation
build(deps-dev): bump oxlint to 1.86.0 - #49
Conversation
Bumps the development group with 2 updates: [oxlint](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxlint) and [tsdown](https://github.com/rolldown/tsdown). Updates `oxlint` from 1.85.0 to 1.86.0 - [Release notes](https://github.com/oxc-project/oxc/releases) - [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxlint/CHANGELOG.md) - [Commits](https://github.com/oxc-project/oxc/commits/oxlint_v1.86.0/npm/oxlint) Updates `tsdown` from 0.22.14 to 0.23.0 - [Release notes](https://github.com/rolldown/tsdown/releases) - [Commits](rolldown/tsdown@v0.22.14...v0.23.0) --- updated-dependencies: - dependency-name: oxlint dependency-version: 1.86.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development - dependency-name: tsdown dependency-version: 0.23.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed October 3, 2026, 12:36 AM ET / 04:36 UTC (Revision 6). ClawSweeper reviewWhat this changesUpdates the locked development linter to oxlint 1.86.0 and refreshes compatible bundler dependencies while retaining tsdown 0.22.14. Merge readiness✅ Ready for maintainer review The prior Node 25 compatibility blocker is resolved, and no actionable defect remains. This PR is still useful because main and the latest release retain oxlint 1.85.0. Priority: P3 Review scores
Verification
How this fits togetherUIRouter’s development tools lint TypeScript source and build the published router package. The lockfile selects the tool versions used by contributor installations and CI. flowchart TD
A[Package requirements] --> B[Frozen dependency installation]
C[Locked tool versions] --> B
B --> D[TypeScript linting]
B --> E[Package build]
D --> F[Quality checks]
E --> F
Before mergeNone. Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Retain the compatible Node support contract while adopting the verified development-tool refresh. Do we have a high-confidence way to reproduce the issue? Not applicable to the remaining dependency refresh; source inspection confirms the prior incompatible engine declarations were removed, and the maintainer reports successful Node 25 installation and checks. Is this the best way to solve the issue? Yes. Retaining the compatible bundler versions while refreshing supported tooling preserves the established Node contract without changing router APIs. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 07fab057ebd5. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (5 earlier review cycles)
|
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
@clawsweeper re-review The Node 25-compatible |
|
🦞👀 Re-review progress:
|
What Problem This Solves
The grouped development-tool update included
tsdown@0.23.0, which explicitly drops Node 25 even though UIRouter declares Node 25 support and uses strict engine checks.Why This Change Was Made
Keep Dependabot's
oxlint@1.86.0lock refresh while restoringtsdown@0.22.14and its Node 25-compatible dependency graph. This changes development tooling only; it does not change the router runtime or package output contract.User Impact
Contributors retain the supported Node 25 development path while receiving the newer linter. No release is required.
Evidence
25.9.0:pnpm install --frozen-lockfileandpnpm run checkpassed withtsdown@0.22.14; 58 tests passed.22.22.3: forced frozen reinstall andpnpm run checkpassed; 58 tests passed.24.21.0: forced frozen reinstall andpnpm run checkpassed; 58 tests passed.git diff --checkpassed.The pre-fix Node 25 frozen install and full check also completed despite the locked package declaring an incompatible engine range. The repair follows the dependency's explicit engine contract rather than relying on that pnpm enforcement quirk.
ClawSweeper rank-up move addressed: the compatible bundler graph is restored and frozen installation plus the full package check were verified on Node 25.
Dependabot remains credited as the pull request author and co-author of the maintainer repair commit.