Repository navigation
build(deps-dev): update Node types and oxlint type-aware checks - #56
Conversation
Bumps the development group with 3 updates: [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node), [oxlint-tsgolint](https://github.com/oxc-project/tsgolint) and [tsdown](https://github.com/rolldown/tsdown). Updates `@types/node` from 26.6.4 to 26.6.5 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `oxlint-tsgolint` from 7.0.2003 to 7.0.2004 - [Release notes](https://github.com/oxc-project/tsgolint/releases) - [Commits](oxc-project/tsgolint@v7.0.2003...v7.0.2004) Updates `tsdown` from 0.22.14 to 0.23.1 - [Release notes](https://github.com/rolldown/tsdown/releases) - [Commits](rolldown/tsdown@v0.22.14...v0.23.1) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 26.6.5 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development - dependency-name: oxlint-tsgolint dependency-version: 7.0.2004 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development - dependency-name: tsdown dependency-version: 0.23.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR updates locked Node types to 26.6.5 and oxlint-tsgolint to 7.0.2004 while retaining tsdown 0.22.14. Example: A contributor installs the locked development tools.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review This PR remains useful: main retains the older dependencies, the previous Node 25 blocker is fixed, and exact-head CI passes with no actionable findings. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe lockfile selects development tools used to typecheck, lint, build, and validate the standalone router package. flowchart LR
A[Package dependency ranges] --> B[PNPM lockfile]
B --> C[Frozen development install]
C --> D[Typecheck and lint]
C --> E[Build and package validation]
Technical reviewBest possible solution: Land the compatible lockfile refresh while preserving the supported Node range and existing bundler graph. Do we have a high-confidence way to reproduce the issue? The earlier Node 25 failure no longer applies to this head: the incompatible bundler upgrade is absent and exact-head frozen installation succeeds. Is this the best way to solve the issue? The narrowed lockfile update follows the established compatibility approach and avoids changing supported runtimes or router behavior. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 2c8ca576fe4e. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Review metrics
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (2 earlier review cycles)Reviewed October 14, 2026, 12:46 AM ET / 04:46 UTC (Revision 3). |
Updates the compatible development dependencies: @types/node 26.6.4 → 26.6.5 and oxlint-tsgolint 7.0.2003 → 7.0.2004.
Retains tsdown 0.22.14 and its existing dependency graph. tsdown 0.23.1 requires Node ^22.18 || ^24.11 || >=26, so it rejects this project’s supported Node 25 CI lane during frozen installation. The supported runtime matrix and strict engine checks remain unchanged. Revisit the tsdown update when its engine contract supports this lane or the project explicitly changes its supported Node versions.
Validation: fresh exact-head CI must pass across Node 22/24 on Linux, macOS and Windows, plus Node 25 on Linux; each lane performs frozen install, lint, formatting, checks, tests and build. No release or publication is part of this update.