Skip to content

build(deps-dev): update Node types and oxlint type-aware checks - #56

Merged
vincentkoc merged 2 commits into
mainfrom
dependabot/npm_and_yarn/development-6d3fde954c
Oct 14, 2026
Merged

vincentkoc merged 2 commits into
mainfrom
dependabot/npm_and_yarn/development-6d3fde954c

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Updates the compatible development dependencies: @types/node 26.6.4 → 26.6.5 and oxlint-tsgolint 7.0.2003 → 7.0.2004.

Retains tsdown 0.22.14 and its existing dependency graph. tsdown 0.23.1 requires Node ^22.18 || ^24.11 || >=26, so it rejects this project’s supported Node 25 CI lane during frozen installation. The supported runtime matrix and strict engine checks remain unchanged. Revisit the tsdown update when its engine contract supports this lane or the project explicitly changes its supported Node versions.

Validation: fresh exact-head CI must pass across Node 22/24 on Linux, macOS and Windows, plus Node 25 on Linux; each lane performs frozen install, lint, formatting, checks, tests and build. No release or publication is part of this update.

Bumps the development group with 3 updates: [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node), [oxlint-tsgolint](https://github.com/oxc-project/tsgolint) and [tsdown](https://github.com/rolldown/tsdown).


Updates `@types/node` from 26.6.4 to 26.6.5
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `oxlint-tsgolint` from 7.0.2003 to 7.0.2004
- [Release notes](https://github.com/oxc-project/tsgolint/releases)
- [Commits](oxc-project/tsgolint@v7.0.2003...v7.0.2004)

Updates `tsdown` from 0.22.14 to 0.23.1
- [Release notes](https://github.com/rolldown/tsdown/releases)
- [Commits](rolldown/tsdown@v0.22.14...v0.23.1)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 26.6.5
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development
- dependency-name: oxlint-tsgolint
  dependency-version: 7.0.2004
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development
- dependency-name: tsdown
  dependency-version: 0.23.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot requested a review from a team as a code owner October 14, 2026 00:43
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Oct 14, 2026
@clawsweeper

clawsweeper Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Oct 14, 2026
@clawsweeper

clawsweeper Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

This PR updates locked Node types to 26.6.5 and oxlint-tsgolint to 7.0.2004 while retaining tsdown 0.22.14.

Example: A contributor installs the locked development tools.

  • Before: The install selects @types/node 26.6.4 and oxlint-tsgolint 7.0.2003.
  • After: The install selects @types/node 26.6.5 and oxlint-tsgolint 7.0.2004, with Node 25-compatible tsdown unchanged.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused dependency refresh with the previous compatibility defect fixed, passing exact-head checks, and no actionable findings.
Proof confidence 🌊 off-meta tidepool Not applicable: This bot-authored development dependency update is outside the ordinary contributor proof gate; exact-head CI supports installation and toolchain compatibility without constituting shipped router behavior proof.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Contributors use older patch releases of Node declarations and type-aware lint tooling.
Reason: The update is narrowly scoped and preserves the development compatibility contract established by prior merged tooling refreshes.

Merge readiness

✅ Ready for maintainer review

This PR remains useful: main retains the older dependencies, the previous Node 25 blocker is fixed, and exact-head CI passes with no actionable findings.

Priority: P3
Reviewed head: dd8b29930056f4f8b57e3280f2c920256e0ee225

Before merge

None.

Findings

None.

Agent review details

How this fits together

The lockfile selects development tools used to typecheck, lint, build, and validate the standalone router package.

flowchart LR
  A[Package dependency ranges] --> B[PNPM lockfile]
  B --> C[Frozen development install]
  C --> D[Typecheck and lint]
  C --> E[Build and package validation]
Loading

Technical review

Best possible solution:

Land the compatible lockfile refresh while preserving the supported Node range and existing bundler graph.

Do we have a high-confidence way to reproduce the issue?

The earlier Node 25 failure no longer applies to this head: the incompatible bundler upgrade is absent and exact-head frozen installation succeeds.

Is this the best way to solve the issue?

The narrowed lockfile update follows the established compatibility approach and avoids changing supported runtimes or router behavior.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 2c8ca576fe4e.

Provenance checked

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

Likely related people:

  • Peter Steinberger: Raw commit 292a54d adds pnpm-lock.yaml:19 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 292a54dcf5d4; files: pnpm-lock.yaml)

Review metrics

Metric Value Why it matters
Change scope Lockfile +45/-45; production source +0/-0; tests +0/-0 The changes are dependency resolution updates without production code growth.

Labels

Label changes:

  • add P3: This is a compatible development-tool patch refresh with no router behavior change or remaining installation regression.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.
  • remove status: ⏳ waiting on author: Current PR status label is status: 👀 ready for maintainer look.
  • remove P2: Current review triage priority is P3, so this older priority label is no longer current.
  • remove rating: 🧂 unranked krab: Current PR rating is rating: 🐚 platinum hermit, so this older rating label is no longer current.
  • remove merge-risk: 🚨 compatibility: Current PR review selected no merge-risk labels.

Label justifications:

  • P3: This is a compatible development-tool patch refresh with no router behavior change or remaining installation regression.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (2 earlier review cycles)
  • reviewed 2026-10-14T00:47:30.753Z sha 1b61f14 :: needs changes before merge. :: [P1] Restore the Node 25-compatible tsdown dependency graph
  • reviewed 2026-10-14T03:02:59.972Z sha 1b61f14 :: needs changes before merge. :: [P1] Restore the Node 25-compatible tsdown dependency graph

Reviewed October 14, 2026, 12:46 AM ET / 04:46 UTC (Revision 3).

@vincentkoc vincentkoc changed the title build(deps-dev): bump the development group with 3 updates build(deps-dev): update Node types and oxlint type-aware checks Oct 14, 2026
@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. P2 Normal priority bug or improvement with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. labels Oct 14, 2026
@vincentkoc
vincentkoc merged commit 251c5f1 into main Oct 14, 2026
17 checks passed
@vincentkoc
vincentkoc deleted the dependabot/npm_and_yarn/development-6d3fde954c branch October 14, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant