Repository navigation
build(deps-dev): bump the development group with 3 updates - #60
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the development group with 3 updates: [oxfmt](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxfmt), [oxlint](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxlint) and [tsdown](https://github.com/rolldown/tsdown). Updates `oxfmt` from 0.72.0 to 0.73.0 - [Release notes](https://github.com/oxc-project/oxc/releases) - [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxfmt/CHANGELOG.md) - [Commits](https://github.com/oxc-project/oxc/commits/oxfmt_v0.73.0/npm/oxfmt) Updates `oxlint` from 1.87.0 to 1.88.0 - [Release notes](https://github.com/oxc-project/oxc/releases) - [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxlint/CHANGELOG.md) - [Commits](https://github.com/oxc-project/oxc/commits/oxlint_v1.88.0/npm/oxlint) Updates `tsdown` from 0.22.14 to 0.23.1 - [Release notes](https://github.com/rolldown/tsdown/releases) - [Commits](rolldown/tsdown@v0.22.14...v0.23.1) --- updated-dependencies: - dependency-name: oxfmt dependency-version: 0.73.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development - dependency-name: oxlint dependency-version: 1.88.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development - dependency-name: tsdown dependency-version: 0.23.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs changes before merge. What this changesThis PR updates oxfmt to 0.73.0, the locked oxlint to 1.88.0, and tsdown to 0.23.1 with their transitive dependencies. Example: A contributor installs development dependencies on Node 25 using pnpm install --frozen-lockfile.
Review scores
ProductKind: Maintenance · Worth it: Yes Merge readiness⛔ Needs changes before merge - 2 items remain Keep this PR open for a narrow repair: the tooling refresh is useful, but its tsdown upgrade breaks supported Node 25 development installs and reverses an explicit maintainer decision. Priority: P2 Before merge
Findings
Provenance
Agent review detailsHow this fits togetherThese development dependencies format, lint, and compile the router source into its published ESM and TypeScript declarations; they are outside the router's runtime dependency graph. flowchart LR
A[Contributor or CI] --> B[pnpm frozen install]
B --> C[Dependency engine checks]
C --> D[Formatter and linter]
C --> E[tsdown and declaration generator]
E --> F[Packed ESM package]
Technical reviewBest possible solution: Keep the formatter and linter updates while restoring tsdown 0.22.14 and its Node 25-compatible dependency graph. Do we have a high-confidence way to reproduce the issue? The incompatible dependency engine ranges and engineStrict setting establish the failure path; exact-head CI confirms installation fails on Node 25 while main passes, although redirected job logs were inaccessible. Is this the best way to solve the issue? A compatible tooling refresh is appropriate, but upgrading tsdown across its Node 25 support removal contradicts recorded maintainer direction; restoring the existing bundler graph is the narrow repair. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 251c5f19a107. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceAcceptance criteria:
What I checked:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 15, 2026, 3:08 PM ET / 19:08 UTC. |
Update oxfmt to 0.73.0 and oxlint to 1.88.0 while preserving the complete Node 25-compatible tsdown 0.22.14 dependency graph and strict engine checks. All seven supported CI lanes, CodeQL, independent P0–P3 autoreview, and exact-head ClawSweeper review passed. Preserves the useful Dependabot contribution from #60; a replacement was necessary because that branch does not allow maintainer edits. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Superseded by #61, squash-merged as f33fdcb. The replacement preserves this original Dependabot commit and credits Dependabot in the landed commit. It retains oxfmt 0.73.0 and oxlint 1.88.0 while restoring the complete tsdown 0.22.14 / declaration-generator graph required for supported Node 25 installs. A replacement was necessary because this branch does not allow maintainer edits. All seven supported CI lanes, CodeQL, independent P0–P3 autoreview, and exact-head ClawSweeper review passed. Thanks @dependabot. |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Bumps the development group with 3 updates: oxfmt, oxlint and tsdown.
Updates
oxfmtfrom 0.72.0 to 0.73.0Release notes
Sourced from oxfmt's releases.
Changelog
Sourced from oxfmt's changelog.
... (truncated)
Commits
6941b4erelease(apps): oxlint v1.88.0 && oxfmt v0.73.0 (#27643)a495e82feat(oxfmt): supportassociationsconfig to specify language over filepath ...408d87fdocs(oxfmt): simplify oxfmtrc docs (#27432)5db28fafeat(oxfmt): support Astro viaprettier-plugin-astro@1.x(#27386)902e188docs(oxfmt): update howembeddedLanguageFormattingoption works (#27362)Updates
oxlintfrom 1.87.0 to 1.88.0Release notes
Sourced from oxlint's releases.
Changelog
Sourced from oxlint's changelog.
... (truncated)
Commits
6941b4erelease(apps): oxlint v1.88.0 && oxfmt v0.73.0 (#27643)3c361a7feat(linter/unicorn/prefer-query-selector): addallowWithVariablesoption (...Updates
tsdownfrom 0.22.14 to 0.23.1Release notes
Sourced from tsdown's releases.
... (truncated)
Commits
6493257chore: release v0.23.1ba6acb9chore: upgrade deps6cbfec7chore(deps): update dependency unplugin-vue to v8 (#1090)eb40c95chore: declare package side effectsf9c95d0chore: align pnpm workspace settingse64bde4chore: configure pnpm via devEngines83f0c57fix(pkg): pack tarball insidenpm publish --dry-run(#1076)1745223fix(entry): honor custom root for object entry (#1072)9655dcbchore: upgrade deps30da631docs: correct default value ofminifyDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions