Repository navigation
build(deps-dev): update formatter and linter with Node 25 support - #61
Conversation
Bumps the development group with 3 updates: [oxfmt](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxfmt), [oxlint](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxlint) and [tsdown](https://github.com/rolldown/tsdown). Updates `oxfmt` from 0.72.0 to 0.73.0 - [Release notes](https://github.com/oxc-project/oxc/releases) - [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxfmt/CHANGELOG.md) - [Commits](https://github.com/oxc-project/oxc/commits/oxfmt_v0.73.0/npm/oxfmt) Updates `oxlint` from 1.87.0 to 1.88.0 - [Release notes](https://github.com/oxc-project/oxc/releases) - [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxlint/CHANGELOG.md) - [Commits](https://github.com/oxc-project/oxc/commits/oxlint_v1.88.0/npm/oxlint) Updates `tsdown` from 0.22.14 to 0.23.1 - [Release notes](https://github.com/rolldown/tsdown/releases) - [Commits](rolldown/tsdown@v0.22.14...v0.23.1) --- updated-dependencies: - dependency-name: oxfmt dependency-version: 0.73.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development - dependency-name: oxlint dependency-version: 1.88.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development - dependency-name: tsdown dependency-version: 0.23.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
@clawsweeper re-review The replacement preserves the original Dependabot commit and addresses both before-merge items from #60: restore the complete Node 25-compatible build/declaration graph and retain the recorded maintainer intent. Please review exact head |
|
🦞👀 Re-review progress:
|
|
Codex review: needs maintainer review before merge. What this changesThis PR updates oxfmt to 0.73.0 and locked oxlint to 1.88.0 while retaining main’s compatible build dependency graph. Example: A contributor installs development dependencies on Node 25 with pnpm install --frozen-lockfile.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open: it preserves the approved Node 25 tooling contract, introduces useful dependency updates absent from main, and has no actionable findings; all seven exact-head package CI jobs pass. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThese development dependencies format, lint, and compile router source into ESM and TypeScript declarations; they add no router runtime dependencies. flowchart LR
A[Contributor or CI] --> B[pnpm frozen install]
B --> C[Strict engine checks]
C --> D[Formatter and linter]
C --> E[Bundler and declaration generator]
E --> F[Packed router package]
Technical reviewBest possible solution: Retain this focused formatter/linter update with main’s complete Node 25-compatible build graph. Do we have a high-confidence way to reproduce the issue? This is maintenance rather than a current-main bug; source comparison and exact-head CI establish that the replacement preserves supported Node 25 installation. Is this the best way to solve the issue? The narrow update follows recorded maintainer direction and avoids the incompatible bundler upgrade in the original Dependabot proposal. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 251c5f19a107. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 16, 2026, 10:31 AM ET / 14:31 UTC. |
What Problem This Solves
Updates the formatter and linter while preserving supported Node 25 development installs.
User Impact
Contributors receive oxfmt 0.73.0 and oxlint 1.88.0 with the existing Node support and strict engine checks. The router API and runtime output contract are unchanged.
Why This Change Was Made
This preserves Dependabot's original update commit from #60. Its branch does not allow maintainer edits, so this replacement restores tsdown 0.22.14 and the complete compatible bundler/declaration dependency graph while retaining the formatter and linter updates. The newer tsdown and declaration generator explicitly exclude Node 25, causing the original PR's installation failure.
Retaining Node 25 follows the existing maintainer decision: #58 (comment). This addresses both original ClawSweeper before-merge items: restore the compatible graph and preserve its recorded intent. Thanks @dependabot.
Evidence
git diff --checkpasses. Source and tests are unchanged; production/test LOC delta is 0/0.pnpm run checkpass with 58 tests across 9 files: https://github.com/openclaw/uirouter/actions/runs/38915743087/job/117022617073.scoped-clean, exit 0, no findings. Exact-head ClawSweeper review also has no findings or before-merge items: build(deps-dev): update formatter and linter with Node 25 support #61 (comment).ready_for_review; its existing workflow was dispatched once on this branch to provide the missing analysis. No workflow changes are included.Related: #60