Repository navigation
chore(ci): share BDD setup with trusted cache saves - #4186
Draft
strantalis wants to merge 5 commits into
Draft
strantalis wants to merge 5 commits into
strantalis wants to merge 5 commits into
Conversation
Signed-off-by: strantalis <strantalis@virtru.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
strantalis
added this pull request to stack #4189
October 7, 2026 11:02
This was referenced Oct 7, 2026
Contributor
Signed-off-by: strantalis <strantalis@virtru.com>
Signed-off-by: strantalis <strantalis@virtru.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
2 tasks done
strantalis
removed this pull request from stack #4189
October 7, 2026 11:24
strantalis
added this pull request to stack #4191
October 7, 2026 11:24
strantalis
changed the title
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
Signed-off-by: strantalis <strantalis@virtru.com>
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
Signed-off-by: strantalis <strantalis@virtru.com>
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
|
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack merge order: release cache policy → shared BDD setup and Go cache → readiness polling → Docker cache.
Proposed Changes
BDD and authorization-scale repeat the same setup and previously required two cache-poisoning exclusions. Put their steps in one reusable workflow with a single
scaleboolean, disable implicitsetup-gocaching, and restore Go module/compiler caches explicitly. Only successful functional BDD runs from pushes tomainsave the shared cache. PR and scale runs restore only, so a dependency change can stay cold until it reachesmain.Keep the functional/scale tags, functional randomization, report names, 20-minute test timeout, and
-count=1. Preserve the requiredcidependency on thetests-bddcaller and leave scale report-only. Both jobs use read-only contents permissions and no workflow secrets. Compilation remains a separate timed step. The shared workflow has no release trigger, and both cache-poisoning exclusions are removed.Release builds consume fresh dependencies in the prerequisite PR. Native
cache-modesyntax is omitted because current actionlint does not support it; restore/save actions implement the cache policy with GitHub's existing branch/ref scoping.Checklist
Testing Instructions
The two BDD callers retain
./with inlineself-repositoryexceptions because current actionlint v1.7.12 rejects GitHub's recommended$/syntax for reusable workflow calls. GitHub resolves both forms to the caller's same commit. These exceptions cover only that syntax recommendation. The shared BDD workflow still has no cache-poisoning exceptions.actionlintpasses for the caller, reusable BDD workflow, focused CI test workflow, and CLI release workflow.checks.yamljobs: four cache-poisoning and two self-repository advisories.cukesand the current workspace dependencies.-count=1, and nonzero-exit propagation match the intended behavior.git diff --checkpasses.Compare cache-hit runs after a successful push to
mainhas populated the cache, recording compilation time, restore/save overhead, total duration, and executed scenario count. PR reruns do not populate their own cache. Historical baseline runs in the README predate the dependency update in #4177, so compare the layers with the same dependency set. Warm CI savings remain unmeasured.