Repository navigation
chore(ci): reduce BDD readiness polling delay - #4187
Draft
strantalis wants to merge 5 commits into
Draft
strantalis wants to merge 5 commits into
strantalis wants to merge 5 commits into
Conversation
Signed-off-by: strantalis <strantalis@virtru.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
strantalis
added this pull request to stack #4189
October 7, 2026 11:02
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
This was referenced Oct 7, 2026
strantalis
changed the title
Contributor
Signed-off-by: strantalis <strantalis@virtru.com>
Contributor
X-Test Failure Report |
2 tasks done
strantalis
removed this pull request from stack #4189
October 7, 2026 11:24
strantalis
added this pull request to stack #4191
October 7, 2026 11:24
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
Signed-off-by: strantalis <strantalis@virtru.com>
Contributor
X-Test Failure Report |
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
Signed-off-by: strantalis <strantalis@virtru.com>
Contributor
X-Test Failure Report |
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
Signed-off-by: strantalis <strantalis@virtru.com>
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
|
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack merge order: release cache policy → shared BDD setup and Go cache → readiness polling → Docker cache.
Proposed Changes
The BDD harness sleeps for one second after each failed Platform health probe. Across 85 Platform startups this can add substantial idle time: baseline run 37528870922 spent about 93s in readiness waits.
Poll every 100ms, retain the 200ms request timeout, and use a 40s overall deadline to preserve the old startup allowance. Propagate scenario cancellation into pending HTTP requests and close every probe response body. Policy/database isolation and the all-services health requirement stay unchanged.
This is the readiness layer of the BDD performance stack. Measure startup and total BDD duration after the Go-cache layer lands, then compare this layer separately.
Checklist
Testing Instructions
make fmtwith pinned golangci-lint v2.13.2 passes.make lintencounters existing SDK/service/CLI lint findings.govulncheckreports vulnerabilities in unchanged dependencies and the local Go 1.26.3 standard library.make testpasses fixture/SDK/service unit tests but fails in existingservice/rttestsbecause localhost:8080 has no running Platform. Infrastructure was supplied for Keycloak and testcontainers Postgres; the external round-trip stack was not provisioned.GOFLAGS=-short make testpasses across all workspace modules with race detection.git diff --checkpasses. Full functional BDD validation is delegated to the PR workflow.The existing functional and scale BDD jobs exercise Platform startup. Both passed on the previous head. The extra unit tests of BDD setup were removed; the tagged BDD test binary still compiles. Existing commits are preserved through signed additive merges.