Skip to content

fix(authz): scope uncached decisions to requested attribute policy - #4192

Draft
strantalis wants to merge 7 commits into
mainfrom
codex/authz-uncached/policy-read
Draft

strantalis wants to merge 7 commits into
mainfrom
codex/authz-uncached/policy-read

Conversation

@strantalis

@strantalis strantalis commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Proposed Changes

Uncached direct-entitlement and dynamic-mapping decisions currently scan all attributes and mappings. Fetch policy for the requested attribute FQNs through GetEntitleableAttributesByFqns, including relevant dynamic mappings and the state needed to deny inactive values.

The PDP controls feature evaluation. Cached decisions and entitlement enumeration keep their existing paths. Registered-resource and obligation reads are unchanged.

Testing Instructions

Focused authorization and policy integration race tests, SDK README tests, and changed-code lint passed. BDD and scale jobs passed for this exact commit; overall CI was incomplete because cross-SDK and CLI jobs were cancelled. Fresh CI against main is pending.

Full local checks encountered container/service startup failures and existing lint findings.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added comp:db DB component comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) docs Documentation labels Oct 7, 2026
@strantalis
strantalis added this pull request to stack #4195 October 7, 2026 15:44
@github-actions github-actions Bot added the size/m label Oct 7, 2026
@strantalis strantalis changed the title codex/authz uncached/policy read feat(policy): resolve unprovisioned values and relevant dynamic mappings Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 393.340971ms
Throughput 254.23 requests/second

TDF3 Benchmark Results

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 42.046314177s
Average Latency 418.827205ms
Throughput 118.92 requests/second

Signed-off-by: strantalis <strantalis@virtru.com>
@strantalis
strantalis force-pushed the codex/authz-uncached/policy-read branch from 03a0eed to 3bd2edc Compare October 7, 2026 18:22
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 224.834787ms
Throughput 444.77 requests/second

TDF3 Benchmark Results

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 25.811018911s
Average Latency 257.510668ms
Throughput 193.72 requests/second

Signed-off-by: strantalis <strantalis@virtru.com>
Signed-off-by: strantalis <strantalis@virtru.com>
Signed-off-by: strantalis <strantalis@virtru.com>
Signed-off-by: strantalis <strantalis@virtru.com>
Signed-off-by: strantalis <strantalis@virtru.com>
Signed-off-by: strantalis <strantalis@virtru.com>
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 325.083078ms
Throughput 307.61 requests/second

TDF3 Benchmark Results

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 38.86308406s
Average Latency 387.883616ms
Throughput 128.66 requests/second

@strantalis
strantalis removed this pull request from stack #4195 October 8, 2026 14:08
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

X-Test Failure Report

@strantalis strantalis changed the title feat(policy): resolve unprovisioned values and relevant dynamic mappings perf(authz): scope uncached decisions to requested attribute policy Oct 8, 2026
@strantalis strantalis changed the title perf(authz): scope uncached decisions to requested attribute policy fix(authz): scope uncached decisions to requested attribute policy Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 352.036158ms
Throughput 284.06 requests/second

TDF3 Benchmark Results

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 37.845420029s
Average Latency 377.802107ms
Throughput 132.12 requests/second

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

  • otdfctl
  • service
  • tests-bdd

See the workflow run for details.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:db DB component comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) docs Documentation size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant