Repository navigation
feat(xtest): decision-first benchmark report with provenance and artifact links - #661
Draft
dmihalcik-virtru wants to merge 1 commit into
Draft
dmihalcik-virtru wants to merge 1 commit into
dmihalcik-virtru wants to merge 1 commit into
Conversation
…fact links Stage 6 of the DSPX-4372-t1 plan: the presentation from #621, rebuilt on the structured result. - perf/presentation.py (new): status (PASS, REGRESSION, INCONCLUSIVE, PARTIAL, UNTRUSTWORTHY, NOTHING MEASURED, NEUTRAL), compared builds with requested refs, commits and diff links from the installation manifest, an underpowered-budget warning, the attention table with the effect strip, candidate comparisons, Braille round traces, every measurement, skipped cells, and run facts. Rendering only: it never decides a verdict or a winner. - perf/publish.py (new): fills the artifact URL into the summary template, or drops those links locally. No placeholder survives either way. - conftest writes <sdk>.md, <sdk>-table.md and <sdk>.summary.md; CI defers the step summary until upload-artifact returns its URL. Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Stage 6 of the six-stage plan. Stacked on #660.
What it does
This brings back #621's report presentation, rebuilt on the structured result from stages 3–5:
perf/presentation.pyis rendering only: it never decides a verdict, a correction family or a winner. It shows:perf.conclusions.perf/publish.pyfills the artifact URL into the summary template onceupload-artifactreturns it, or drops those links locally. No placeholder survives either way.<sdk>.md(the summary),<sdk>-table.md(the plain table) and<sdk>.summary.md(the template). CI defers the step summary until the upload's URL is known.Provenance links use
tree/<sha>,commit/<sha>andcompare/<a>...<b>. Those are correct whatever kind of ref an arm was, which #621's release/PR URL guessing wasn't.Validation