Fix PHP 8.5 deprecations: roman_year nullable + (double)→(float) cast

[luca9692]

What

Two PHP 8.5 deprecation fixes:

1. src/datetime.php:212 — roman_year(int $year = null) → roman_year(?int $year = null) (PHP 8.4+ requires explicit nullable on non-nullable type with default null)
2. src/validation.php:130 — (double)$value cast → (float)$value (PHP 8.5 deprecates non-canonical (double) cast)

Why

Used by gescat-laravel on PHP 8.5 — these surface as runtime Deprecated notices and will become fatal in PHP 8.6+.

Compatibility

Both changes are semantic no-ops (same behavior, explicit syntax). No breaking changes.

Patches

• 1877684 datetime.php
• 79af1b6 validation.php

[Copilot]

Pull request overview

This PR addresses PHP 8.5 deprecation notices by updating two helper functions in the support library to use canonical/explicit typing and casting syntax.

Changes:

• Update roman_year() to explicitly accept nullable input (?int $year = null) to avoid deprecation for non-nullable typed params with null defaults.
• Replace deprecated (double)$value cast with canonical (float)$value in isIntegerFloatingPoint().

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/datetime.php	Makes roman_year() parameter explicitly nullable to avoid PHP 8.4+ deprecation notices.
src/validation.php	Switches (double) to (float) cast in integer-floating-point validation logic for PHP 8.5 compatibility.

Comments suppressed due to low confidence (1)

src/datetime.php:216

• Now that the parameter is typed as ?int, the is_numeric($year) check is effectively just a null check (ints are always numeric). Using $year === null (or renaming the condition/comment) would make the intent clearer and avoid implying non-int inputs are expected.

function roman_year(?int $year = null): string
{
    if (!is_numeric($year)) {
        $year = (int)date('Y');
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.