Skip to content

Fix PHP 8.5 deprecations: roman_year nullable + (double)→(float) cast #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luca9692 wants to merge 2 commits into from
Closed

Fix PHP 8.5 deprecations: roman_year nullable + (double)→(float) cast #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1877684
:wrench: roman_year() explicit nullable param (PHP 8.5 deprecation)
luca9692 May 27, 2026
79af1b6
:wrench: replace (double) cast with (float) (PHP 8.5 deprecation)
luca9692 May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/datetime.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ function carbon(string $date, string $format = DATE_TIME_FORMAT_ISO): Carbon\Car
* @return string
* @see https://github.com/spatie-custom/blender/blob/master/app/Foundation/helpers.php
*/
function roman_year(int $year = null): string
function roman_year(?int $year = null): string
{
if (!is_numeric($year)) {
$year = (int)date('Y');
Expand Down
2 changes: 1 addition & 1 deletion src/validation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ function isIntegerFloatingPoint($value, $unsigned = true): bool
&& $value <= PHP_INT_MAX && $value >= PHP_INT_MIN
//big number rouned to int aproximately!
//big number change into exp format
&& ((int)((double)$value) == $value || (int)$value == $value || strpos(strtoupper((string)$value),
&& ((int)((float)$value) == $value || (int)$value == $value || strpos(strtoupper((string)$value),
'E') === false);
Comment on lines +130 to 131
}

Expand Down