revised docs#859
Merged
Merged
Conversation
|
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
DanielBadura
approved these changes
Jun 12, 2026
DanielBadura
left a comment
DanielBadura
left a comment
Member
There was a problem hiding this comment.
really like it, 2 minor things
Comment on lines
-181
to
-183
| if (!$nameValidator($command->name)) { | ||
| throw new InvalidArgument(); | ||
| } |
Member
There was a problem hiding this comment.
why the removal of this part?
Member
Author
There was a problem hiding this comment.
Because it is out of scope for this area, and service injection comes later.
Comment on lines
+295
to
297
| /** @var CommandBus $commandBus */ | ||
| $commandBus = new InstantRetryCommandBus( | ||
| $commandBus, |
Member
There was a problem hiding this comment.
Suggested change
| /** @var CommandBus $commandBus */ | |
| $commandBus = new InstantRetryCommandBus( | |
| $commandBus, | |
| /** @var CommandBus $innerCommandBus */ | |
| $innerCommandBus | |
| $commandBus = new InstantRetryCommandBus( | |
| $innerCommandBus, |
Member
Author
There was a problem hiding this comment.
this code is not valid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.