-
Notifications
You must be signed in to change notification settings - Fork 14
revised docs #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
revised docs #859
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -137,7 +137,7 @@ final class Profile extends BasicAggregateRoot | |||||||||||||||||
| } | ||||||||||||||||||
| ``` | ||||||||||||||||||
| :::tip | ||||||||||||||||||
| You can find more information about aggregates [here](aggregate.md). | ||||||||||||||||||
| You can find more information about [aggregates](aggregate.md). | ||||||||||||||||||
| ::: | ||||||||||||||||||
|
|
||||||||||||||||||
| #### Update Aggregate | ||||||||||||||||||
|
|
@@ -178,10 +178,6 @@ final class Profile extends BasicAggregateRoot | |||||||||||||||||
| #[Handle] | ||||||||||||||||||
| public function changeName(ChangeProfileName $command): void | ||||||||||||||||||
| { | ||||||||||||||||||
| if (!$nameValidator($command->name)) { | ||||||||||||||||||
| throw new InvalidArgument(); | ||||||||||||||||||
| } | ||||||||||||||||||
|
|
||||||||||||||||||
| $this->recordThat(new NameChanged($command->name)); | ||||||||||||||||||
| } | ||||||||||||||||||
|
|
||||||||||||||||||
|
|
@@ -197,7 +193,7 @@ you can use the [Auto Initialize](aggregate.md#auto-initialize) feature. | |||||||||||||||||
|
|
||||||||||||||||||
| You can inject services into aggregate handler methods. | ||||||||||||||||||
| Starting with the second parameter, it automatically tries to inject the service using a service locator. | ||||||||||||||||||
| Standard, it uses the fully qualified class name from the parameter type hint to find the service. | ||||||||||||||||||
| By default, it uses the fully qualified class name from the parameter type hint to find the service. | ||||||||||||||||||
|
|
||||||||||||||||||
| ```php | ||||||||||||||||||
| use Patchlevel\EventSourcing\Aggregate\BasicAggregateRoot; | ||||||||||||||||||
|
|
@@ -296,7 +292,7 @@ use Patchlevel\EventSourcing\CommandBus\CommandBus; | |||||||||||||||||
| use Patchlevel\EventSourcing\CommandBus\InstantRetryCommandBus; | ||||||||||||||||||
| use Patchlevel\EventSourcing\Repository\AggregateOutdated; | ||||||||||||||||||
|
|
||||||||||||||||||
| /** @var CommandBus $store */ | ||||||||||||||||||
| /** @var CommandBus $commandBus */ | ||||||||||||||||||
| $commandBus = new InstantRetryCommandBus( | ||||||||||||||||||
| $commandBus, | ||||||||||||||||||
|
Comment on lines
+295
to
297
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this code is not valid |
||||||||||||||||||
| 3, // maximum number of retries, default is 3 | ||||||||||||||||||
|
|
@@ -339,7 +335,7 @@ There are different types of providers that you can use to register handlers. | |||||||||||||||||
|
|
||||||||||||||||||
| ### Service Handler Provider | ||||||||||||||||||
|
|
||||||||||||||||||
| The classically way to handle commands is to use services. | ||||||||||||||||||
| The classic way to handle commands is to use services. | ||||||||||||||||||
| The `ServiceHandlerProvider` is used to handle commands by invoking methods on services. | ||||||||||||||||||
|
|
||||||||||||||||||
| ```php | ||||||||||||||||||
|
|
||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the removal of this part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it is out of scope for this area, and service injection comes later.