-
Notifications
You must be signed in to change notification settings - Fork 0
ci: add canary-rollout-tests.yml — enforce the engine's bats suite (CI gap from #613/#624) #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+74
−0
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| # Quality gates for the canary-rollout release engine and its pure gate core. | ||
| # | ||
| # The engine + its bats suite were relocated into this repo by #613/#624 but no | ||
| # CI runner came with them, so tests/canary_rollout.bats went unenforced. This | ||
| # workflow closes that gap. | ||
| # | ||
| # Triggered on any PR (or push to main) that touches: | ||
| # - scripts/canary-rollout.sh (orchestrator) | ||
| # - scripts/lib/canary-rollout.sh (pure gate core) | ||
| # - tests/canary_rollout.bats (the suite) | ||
| # - .github/workflows/canary-rollout-tests.yml (this file) | ||
| # | ||
| # Gates (all must pass before merge): | ||
| # 1. shellcheck — static analysis for the orchestrator + pure core | ||
| # 2. bats — the full canary_rollout unit/behaviour suite | ||
| # | ||
| # Standard: the pure core (scripts/lib/canary-rollout.sh) is side-effect-free so | ||
| # the suite can pin gate behaviour without network — the house pattern this | ||
| # engine itself exemplifies. | ||
|
|
||
| name: Canary-rollout Tests | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'scripts/canary-rollout.sh' | ||
| - 'scripts/lib/canary-rollout.sh' | ||
| - 'tests/canary_rollout.bats' | ||
| - '.github/workflows/canary-rollout-tests.yml' | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - 'scripts/canary-rollout.sh' | ||
| - 'scripts/lib/canary-rollout.sh' | ||
| - 'tests/canary_rollout.bats' | ||
| - '.github/workflows/canary-rollout-tests.yml' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: canary-rollout-tests-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Lint and bats | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
| with: | ||
| fetch-depth: 1 | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| persist-credentials: false | ||
|
|
||
| - name: Install bats, shellcheck, and jq | ||
| run: | | ||
| set -euo pipefail | ||
| sudo apt-get update -qq | ||
| sudo apt-get install -y --no-install-recommends bats shellcheck jq | ||
|
|
||
| - name: shellcheck | ||
| run: | | ||
| set -euo pipefail | ||
| shellcheck --severity=warning -x scripts/canary-rollout.sh scripts/lib/canary-rollout.sh | ||
|
|
||
| - name: Run bats suite | ||
| # The suite stubs gh/git via PATH; a dummy token satisfies the | ||
| # orchestrator's token precondition without any real API access. | ||
| env: | ||
| GH_TOKEN: dummy-token-for-stubbed-tests | ||
| run: bats --print-output-on-failure tests/canary_rollout.bats | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paths list leaves out
standards/canary-rings.json, even thoughtests/canary_rollout.batsreads that file asRINGSand contains dedicated assertions for its ring/gate shape. A PR that changes only the registry or gate knobs will therefore skip the workflow entirely, letting broken rollout metadata merge without the bats suite this workflow is meant to enforce; add the registry file to both thepull_requestandpushpath filters.Useful? React with 👍 / 👎.