Skip to content

Entity remove files should not exist in translations - #5711

Open
alfsb wants to merge 1 commit into
php:masterfrom
alfsb:remove-empty-on-translations
Open

Entity remove files should not exist in translations#5711
alfsb wants to merge 1 commit into
php:masterfrom
alfsb:remove-empty-on-translations

Conversation

@alfsb

@alfsb alfsb commented Jul 25, 2026

Copy link
Copy Markdown
Member

Some translations are copying the file contents. Let's reinforce the message. If this fails, there is an option of marking this file as do-not-translate.

Reviews, comments and merges wellcome.

@alfsb

alfsb commented Jul 26, 2026

Copy link
Copy Markdown
Member Author

Note: commit this as [skip-revcheck], so translations that followed instructions are not bothered at first.

@alfsb
alfsb marked this pull request as draft July 27, 2026 22:36
@alfsb

alfsb commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

Back to draft. I'm thinking in opening a survey issue, here or in doc-base, asking if translations see value into having to update the revtag each time this file is changed, to gain diffs, or if it is better to mark this file as do-not-translated, so they are not bothered with this chore.

@alfsb

alfsb commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

As noted in #5722 , I may leave this issue open a few weeks or months, to see if translations chime in. In the case of silence, the course of action will be:

  1. Hard reset the PR branch/
  2. Annotate the file with do-not-translate;
  3. And remove instructions for translations.

Comment thread entities/entities.remove.ent
@alfsb alfsb closed this Aug 28, 2026
@alfsb
alfsb force-pushed the remove-empty-on-translations branch from 0811628 to 4e77868 Compare August 28, 2026 15:26
@alfsb alfsb reopened this Aug 28, 2026
@alfsb
alfsb marked this pull request as ready for review August 28, 2026 15:28
@alfsb

alfsb commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

Reviews, comments and merges welcome. Plan to merge this in one week.

@alfsb alfsb changed the title Entity remove files SHOULD be empty on translations Entity remove files should not exist in translations Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants