Skip to content

Entity remove files should not exist in translations #5711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alfsb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Entity remove files should not exist in translations #5711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion entities/entities.php.ent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ There are a few <filename> tossed near and there.
-->
<entities xmlns = "http://docbook.org/ns/docbook"
xmlns:xlink = "http://www.w3.org/1999/xlink"
translate = "yes">
translate = "no">

<entity name="array"><type>array</type></entity>

Expand Down
43 changes: 6 additions & 37 deletions entities/entities.remove.ent
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,47 +1,16 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- $Revision$ -->
<?do-not-translate?>
<!--

This is a "remove" XML Entity file.
See doc-base/scripts/text-entities.php for details.
You can run this script directly.

# doc-en
This is a "remove" XML Entity file. See
doc-base/scripts/text-entities.php
for details. You can run that script directly.

Place here only deprecated or removed entities that are
expected NOT be being used in any part of the manual.

# Translations, question

First, a question. A file like this, that show entities that got
removed in doc-base/doc-en, AND is tracked by revcheck, helps or
cause more work than it is worth?

Please, leave your comments in the issue issue:
https://github.com/php/doc-en/pull/5711

I (ae) am seriously considering marking this file as do-not-translate,
so it won't appear in revcheck anymore.

# Translations, instructions

If an entity moved here is used in a translation in your control,
this means that the entity on the original files is planned to be
removed, or already was removed, but are temporarily moved here,
to avoid breaking translations.

This file is tracked by revcheck, so translations have a heads up
when an entity is removed from doc-en (by revcheck diff links).
That said, do NOT sync or copy the file CONTENTS in translations,
otherwise doc-base/scripts/text-entities.php will generate wrong
statistics, and worse, it will NOT help your translation in
finding wrong entity usage in your language.

ON TRANSLATIONS, LEAVE <entities/> EMPTY.
ON TRANSLATIONS, ONLY UPDATE THE REVTAG.
expected NOT be being used in any part of the manual, but
are temporarily defined here as to keep translations building.

-->

<entities xmlns = "http://docbook.org/ns/docbook"
xmlns:xlink = "http://www.w3.org/1999/xlink"
translate = "remove">
Expand Down
2 changes: 1 addition & 1 deletion entities/entities.url.ent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ URLs, other addresses and external references.
-->
<entities xmlns = "http://docbook.org/ns/docbook"
xmlns:xlink = "http://www.w3.org/1999/xlink"
translate = "yes">
translate = "no">

<entity name="book.applied.cryptography">Applied Cryptography by Schneier (ISBN 0-471-11709-9)</entity>
<entity name="book.programming.classics">Programming Classics: Implementing the World's Best Algorithms by Oliver (ISBN 0-131-00413-1)</entity>
Expand Down
Loading