zend_hash_sort never fails since PHP 5.5.0#20
Closed
Jan-E wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Compiles fine with PHP 7.4.8 x64 NTS, so should be OK. |
1 similar comment
Contributor
Author
|
@0mars |
Collaborator
|
just add them, and we remove them all later. to keep consistency @Jan-E |
Contributor
Author
|
#21 |
Contributor
Author
remicollet
reviewed
Sep 4, 2020
|
|
||
| RETURN_FALSE; | ||
| } | ||
| zend_hash_sort_ex(doc_entry->fields, zend_qsort, comparison_function, renumber TSRMLS_CC); |
Member
There was a problem hiding this comment.
Simpler to use zend_hash_sort (zend_qsort being dropped in 8)
Other way in pr #22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See php/php-src#3936 (comment)