Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingcap/docs/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (9)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe Japanese release notes for versions 8.5.0 through 8.5.8 receive wording and formatting revisions. The edits clarify selected configuration and issue descriptions, add a planned Lightning setting deprecation, and translate two quick-access labels without changing their links. ChangesRelease note revisions
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The release-note revisions introduce no identified merge-blocking risk. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 LanguageToolLanguageTool checks are incomplete because the process-local organization character budget was exhausted. Remaining chunks and files were skipped; findings from completed checks are retained. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[LGTM Timeline notifier]Timeline:
|
What is changed, added or deleted? (Required)
Fixes translation defects in the Japanese v8.5.x release notes (
releases/release-8.5.0.mdtorelease-8.5.8.md, 9 files). This is the first round of thereleases/review. Each item was checked against its EN bullet (release-8.5).Meaning fixes
storelabel vs.pd_cluster_statusmetric (8.5.5).restore logvs.restore point(8.5.5).ADD INDEXjob vs. itsTHREAD/BATCH_SIZE/MAX_WRITE_SPEEDparameters (8.5.5).QUERY_LIMITvs.COOLDOWN/SWITCH_GROUP(8.5.2).mysql.stats_meta/count(8.5.4).filtersection vs.ignore-txn-start-ts(8.5.4).INsubquery vs. thesemi_join_rewritehint (8.5.4).nilbuffer vs.basePartialResult4GroupConcat(8.5.3).TIDB_SERVERS_INFO/LABELS/BINLOG_STATUSfix (8.5.2).use indexhint withtidb_isolation_read_engines = tiflash(8.5.4).Markdown and literals
|inside two TiKV configuration cells created extra columns. They now use EN's<code>form with escaped pipes.<ul>wrapper in an 8.5.4 table cell.-(8.5.7).@gengliqi(8.5.4).ADMIN CHECKhad been translated.Other fixes:
Not changed here, because they need corpus-wide sweeps rather than per-file fixes (recorded for later):
The
release-8.5.7.mdlines covered by #24133 are not touched.EN-side candidates found here, not changed:
@wintalker.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code
Summary by CodeRabbit