Skip to content

i18n(ja): fix translation defects in the v8.5.x release notes - #24143

Open
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-releases-85x
Open

yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-releases-85x

Conversation

@yahonda

@yahonda yahonda commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Fixes translation defects in the Japanese v8.5.x release notes (releases/release-8.5.0.md to release-8.5.8.md, 9 files). This is the first round of the releases/ review. Each item was checked against its EN bullet (release-8.5).

Meaning fixes

  • Identifiers or roles swapped:
    • store label vs. pd_cluster_status metric (8.5.5).
    • restore log vs. restore point (8.5.5).
    • The ADD INDEX job vs. its THREAD/BATCH_SIZE/MAX_WRITE_SPEED parameters (8.5.5).
    • QUERY_LIMIT vs. COOLDOWN/SWITCH_GROUP (8.5.2).
    • The table vs. the column for mysql.stats_meta/count (8.5.4).
    • The filter section vs. ignore-txn-start-ts (8.5.4).
    • The IN subquery vs. the semi_join_rewrite hint (8.5.4).
    • The nil buffer vs. basePartialResult4GroupConcat (8.5.3).
  • Scrambled or truncated items:
    • The TIDB_SERVERS_INFO/LABELS/BINLOG_STATUS fix (8.5.2).
    • The BR pre-split Regions fix (8.5.6).
    • The use index hint with tidb_isolation_read_engines = tiflash (8.5.4).
    • "executing a prepared statement that begins with a newline character" (8.5.0).
  • Changed meaning:
    • "Upgrade the Go compiler … which improves the TiDB performance" had become an instruction to the reader (8.5.5).
    • "planned for deprecation" had become 廃止 (removal) (8.5.0).
    • "for the physical import mode" was dropped (8.5.0).
    • "might", "at most", "grant", "more", and "use" were dropped (8.5.0, 8.5.5, 8.5.6).
    • The cause and effect of the binding cache corruption and the OOM were inverted (8.5.7).
    • "index restore speed" had become 修復 (8.5.3).
    • The LRU gloss 最小使用頻度 (that is LFU) was wrong (8.5.0).
    • Spill had become 流出 ("leak") (8.5.2, 8.5.5).
    • The EOL tense was wrong (8.5.1).

Markdown and literals

  • A broken table in 8.5.5: raw | inside two TiKV configuration cells created extra columns. They now use EN's <code> form with escaped pipes.
  • The lost <ul> wrapper in an 8.5.4 table cell.
  • Two list items without a space after - (8.5.7).
  • A bold span that split a word (8.5.3).
  • The contributor handle @gengliqi (8.5.4).
  • Active PD Follower and TSO Follower Proxy had been garbled.
  • resolved ts and ADMIN CHECK had been translated.
  • The untranslated "Security", "TiDB version:", and quick-access link texts.

Other fixes:

  • About 15 dropped は/を/が/の after backticks and links.
  • 実験的的.
  • アドバンスダー.
  • The person counter 人 used for a node.

Not changed here, because they need corpus-wide sweeps rather than per-file fixes (recorded for later):

  • Leader/Follower are rendered as リーダー/フォロワー although the glossary keeps the Raft roles in English.
  • "Release date" is rendered as 発売日 (about 140 release files).
  • "compaction" is rendered as 圧縮 in some notes.

The release-8.5.7.md lines covered by #24133 are not touched.

EN-side candidates found here, not changed:

  • 8.5.0: "Staring from".
  • 8.5.0: "functions returns".
  • 8.5.1: backticks around "table".
  • 8.5.2: "despite … is".
  • 8.5.2: possibly @wintalker.
  • 8.5.0 and 8.5.4: list indentation.
  • 8.5.4: a tense mismatch.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified release-note descriptions of configuration settings, defaults, deprecations, compatibility details, and bug fixes across versions 8.5.0–8.5.8.
    • Corrected and refined Japanese and English wording, including descriptions of affected conditions and behavior.
    • Changed quick-access link labels to Japanese; link destinations remain unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 1, 2026
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingcap/docs/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 317ef1bd-ccd4-41ec-8686-075269c136f7

📥 Commits

Reviewing files that changed from the base of the PR and between 053b6de and bea7b0d.

📒 Files selected for processing (9)
  • releases/release-8.5.0.md
  • releases/release-8.5.1.md
  • releases/release-8.5.2.md
  • releases/release-8.5.3.md
  • releases/release-8.5.4.md
  • releases/release-8.5.5.md
  • releases/release-8.5.6.md
  • releases/release-8.5.7.md
  • releases/release-8.5.8.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The Japanese release notes for versions 8.5.0 through 8.5.8 receive wording and formatting revisions. The edits clarify selected configuration and issue descriptions, add a planned Lightning setting deprecation, and translate two quick-access labels without changing their links.

Changes

Release note revisions

Layer / File(s) Summary
8.5.0 clarifications and deprecations
releases/release-8.5.0.md
Clarifies Lightning conflict-setting descriptions and adds the planned deprecation of conflict.max-record-rows, with conflict.threshold identified as its replacement. Other edits revise feature, improvement, and bug-fix wording.
8.5.1–8.5.4 corrections
releases/release-8.5.1.md, releases/release-8.5.2.md, releases/release-8.5.3.md, releases/release-8.5.4.md
Corrects descriptions of settings, SQL behavior, and reported issues. Other edits adjust Japanese wording and formatting.
8.5.5–8.5.8 revisions
releases/release-8.5.5.md, releases/release-8.5.6.md, releases/release-8.5.7.md, releases/release-8.5.8.md
Refines descriptions of configuration, metrics, and bug fixes. The 8.5.8 edits translate two quick-access labels and retain their links.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to bea7b

The release-note revisions introduce no identified merge-blocking risk.

Architecture Summary

Architecture risk: 🔵 Low · up to bea7b

The change affects 1 system.

Changed systems: releases

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — releases (service) was modified; 9 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in releases/release-8.5.0.md: The highlights table changes the security category label from English to Japanese. The schema-cache description revises the Japanese expansion of LRU, and the Active PD Follower entry changes its Japanese wording; the listed features and their described behavior otherwise remain unchanged.
  • observed — Modified behavior in releases/release-8.5.0.md: The MAX_WRITE_SPEED example now describes adjusting index-data write traffic to each TiKV node, removing the prior “online” wording. The client-side full-backup encryption description corrects a duplicated-character typo.
  • observed — Modified behavior in releases/release-8.5.0.md: The deprecated TiDB Lightning conflict-detection strategy is clarified as applying to physical import mode; conflict.strategy controls conflict detection for both logical and physical import modes, and duplicate-resolution remains slated for removal.
  • observed — Modified behavior in releases/release-8.5.0.md: The deprecation notice wording changes from “廃止” to “非推奨.” A new notice says conflict.max-record-rows will be deprecated and later removed, replaced by conflict.threshold, with the limit defined as the maximum conflicting records allowed per import task.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies Japanese translation fixes in the v8.5.x release notes, which matches the primary change.
Description check ✅ Passed The description explains the scope, affected files, corrections, target version branch, related issue, AI involvement, and change categories. It is complete enough for review; the omitted first-time c…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Warning

Some tools did not complete. Review the errors below.

🔧 LanguageTool

LanguageTool checks are incomplete because the process-local organization character budget was exhausted. Remaining chunks and files were skipped; findings from completed checks are retained.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qiancai qiancai added the translation/no-need No need to translate this PR. label Oct 1, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Oct 1, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 1, 2026
@ti-chi-bot

ti-chi-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-10-01 07:12:38.983117433 +0000 UTC m=+866484.208338530: ☑️ agreed by qiancai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants