feat: adds floating terminal layout#2344
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c78fad9 to
df27669
Compare
ApprovabilityVerdict: Needs human review Introduces a new user-facing feature allowing terminals to display in a floating modal layout. While implementation is clean and self-contained, new UI presentation modes warrant human review to validate UX decisions and ensure accessibility. You can customize Macroscope's approvability policy. Learn more. |
df27669 to
2343d3d
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2343d3d. Configure here.
- add terminal layout setting and contract schema - render the thread terminal as a floating dialog when enabled - switch package scripts to run under Bun
2343d3d to
4796964
Compare

Summary
Adds an option to have the terminal in a floating window
Settings page
floating terminal
Note
Low Risk
Primarily UI/presentation changes gated by a new client setting; risk is limited to potential regressions in terminal open/close behavior and layout styling.
Overview
Adds a new client setting
terminalLayout(docked|floating, defaultdocked) and exposes it in Settings so users can choose how the terminal is presented.When set to
floating, the existing terminal drawer is rendered inside a modal-style overlay with backdrop and close controls (including outside-click to dismiss), andThreadTerminalDraweradjusts styling based on layout. Updates header tooltips/aria labels accordingly, and extends persistence/local API tests to include the new setting.Reviewed by Cursor Bugbot for commit f5b32fe. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
[!NOTE]
Add floating terminal layout option to chat view
terminalLayoutsetting ("docked"|"floating") toClientSettingsSchemain settings.ts, defaulting to"docked"."floating", the terminal renders as a modal-like overlay with a backdrop and close button instead of the existing docked drawer.ChatHeadertooltip and aria-label to reflect whether the terminal appears as a window or drawer.Macroscope summarized f5b32fe.