Skip to content

feat: adds floating terminal layout#2344

Open
adamt94 wants to merge 2 commits intopingdotgg:mainfrom
adamt94:feat/floating-terminal
Open

feat: adds floating terminal layout#2344
adamt94 wants to merge 2 commits intopingdotgg:mainfrom
adamt94:feat/floating-terminal

Conversation

@adamt94
Copy link
Copy Markdown

@adamt94 adamt94 commented Apr 25, 2026

Summary

Adds an option to have the terminal in a floating window

  • add a client setting for docked vs floating terminal layout
  • render the existing terminal drawer in a floating window when selected

Settings page

Screenshot 2026-04-25 at 14 35 59

floating terminal

Screenshot 2026-04-25 at 14 36 46

Note

Low Risk
Primarily UI/presentation changes gated by a new client setting; risk is limited to potential regressions in terminal open/close behavior and layout styling.

Overview
Adds a new client setting terminalLayout (docked | floating, default docked) and exposes it in Settings so users can choose how the terminal is presented.

When set to floating, the existing terminal drawer is rendered inside a modal-style overlay with backdrop and close controls (including outside-click to dismiss), and ThreadTerminalDrawer adjusts styling based on layout. Updates header tooltips/aria labels accordingly, and extends persistence/local API tests to include the new setting.

Reviewed by Cursor Bugbot for commit f5b32fe. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

[!NOTE]

Add floating terminal layout option to chat view

  • Adds a terminalLayout setting ("docked" | "floating") to ClientSettingsSchema in settings.ts, defaulting to "docked".
  • When set to "floating", the terminal renders as a modal-like overlay with a backdrop and close button instead of the existing docked drawer.
  • Adds a "Terminal layout" select control in SettingsPanels.tsx so users can switch between docked and floating modes and reset to default.
  • Updates ChatHeader tooltip and aria-label to reflect whether the terminal appears as a window or drawer.

Macroscope summarized f5b32fe.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 25, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 46228c0b-7aff-4eb6-864b-c3304e6137c2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 25, 2026
@adamt94 adamt94 changed the title Add floating terminal layout Adds floating terminal layout Apr 25, 2026
@adamt94 adamt94 force-pushed the feat/floating-terminal branch from c78fad9 to df27669 Compare April 25, 2026 13:42
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Apr 25, 2026

Approvability

Verdict: Needs human review

Introduces a new user-facing feature allowing terminals to display in a floating modal layout. While implementation is clean and self-contained, new UI presentation modes warrant human review to validate UX decisions and ensure accessibility.

You can customize Macroscope's approvability policy. Learn more.

Comment thread apps/web/src/components/ChatView.tsx
@adamt94 adamt94 force-pushed the feat/floating-terminal branch from df27669 to 2343d3d Compare April 25, 2026 14:06
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2343d3d. Configure here.

Comment thread apps/web/src/components/ChatView.tsx Outdated
- add terminal layout setting and contract schema
- render the thread terminal as a floating dialog when enabled
- switch package scripts to run under Bun
@adamt94 adamt94 force-pushed the feat/floating-terminal branch from 2343d3d to 4796964 Compare April 25, 2026 14:22
@adamt94 adamt94 changed the title Adds floating terminal layout feat: adds floating terminal layout Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant