fix(coc): derive routeWebSocket URL from server.url in e2e test 8.4#93
Merged
plusplusoneplusplus merged 1 commit intoMay 15, 2026
Merged
Conversation
The `displayHost` mapping in `createExecutionServer` now collapses `127.0.0.1` to `localhost` (commit b0e8ca9), so `server.url` is `http://localhost:PORT` even when the server is bound to 127.0.0.1. The SPA builds its WebSocket URL from `location.host`, so it connects to `ws://localhost:PORT/ws`. The hardcoded `ws://127.0.0.1:PORT/ws` pattern in `routeWebSocket` no longer matches that URL, so the route never fires, `activeRoute.close()` becomes a no-op, and the "Connection lost — reconnecting…" toast never appears. Derive the WS URL from `server.url` so the pattern stays aligned with whatever display host the server reports. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
websocket-recovery.spec.tstest8.4has been failing onmainsince commitb0e8ca9d(feat(coc): change default bind address from 0.0.0.0 to 127.0.0.1).127.0.0.1to the list of hosts thatcreateExecutionServercollapses tolocalhostfordisplayHost/server.url. The SPA builds its WS URL fromlocation.host, so it now connects tows://localhost:PORT/ws— but the test'spage.routeWebSocketpattern was hardcoded tows://127.0.0.1:PORT/ws, so the route never fired,activeRoutestayednull, the simulated close was a no-op, and the "Connection lost — reconnecting…" toast never appeared.server.urlso the pattern stays aligned with whatever display host the server reports.Test plan
npx tsc --noEmitinpackages/cocpasseswebsocket-recovery.spec.ts) goes greenMade with Cursor