ci: skip publish when the version is already on npm - #20
Merged
Merged
Conversation
npm publish over an existing version is a hard E403, so every merge to master that didn't bump package.json (Dependabot's, and CI-only PRs now that verify-version-bump exempts them) ended in a red publish run — run 33714086138 after #19. Look the version up first, as datto-rmm-api-client and timezest already do; the package is access: restricted, so the lookup uses the read-only NPM_TOKEN while the publish itself stays on OIDC trusted publishing.
robgilbreath
added a commit
that referenced
this pull request
Sep 3, 2026
… authenticate (#21) @pncit/node-quickbooks is access: restricted and the repo has no NPM_TOKEN, so the #20 guard's unauthenticated npm view saw 404 for the current version, reported it unpublished, and the publish step hit the same E403 (run 33715159834). Compare package.json to HEAD^ instead — the rule the private libraries already use — and always attempt on a manual dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every merge to master without a package.json bump ended in a red
publish-on-version-bumprun:npm publishover an existing version is a hard E403 (run 33714086138, after #19). Adds the same "already on npm?" check datto-rmm-api-client and timezest have, gating the publish step on it.@pncit/node-quickbooksisaccess: restricted, so the lookup authenticates with the read-onlyNPM_TOKEN; the publish itself is unchanged (OIDC trusted publishing).Workflow-only change — first PR here to rely on the v2.4.0
verify-version-bumppath exemption (no version bump). Part of pncit/.github#26.