Skip to content

some design tweaks - #144

Open
simonpcouch wants to merge 10 commits into
mainfrom
design-141
Open

some design tweaks#144
simonpcouch wants to merge 10 commits into
mainfrom
design-141

Conversation

@simonpcouch

@simonpcouch simonpcouch commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Closes #141.

Before:

before.mov

With this PR [EDIT: some further tweaks visible in a screenshot below]:

new-look.mov

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

Preview deployed to Connect (dogfood.team.pct.posit.it): https://dogfood.team.pct.posit.it/connect/#/apps/d7a36cae-8f27-448b-a478-61b81fbe3942/draft/364639

Deployed from commit 055be2f.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

Preview deployed to Connect (connect.staging.pct.posit.it): https://connect.staging.pct.posit.it/connect/#/apps/ad662e1b-5048-4acc-9ad7-f9478c92274e/draft/2218

Deployed from commit 055be2f.

@skaltman

Copy link
Copy Markdown
Collaborator

The Working... functionality is really nice. I also like that the stop button is now neutral instead of red.

Generally, the spacing and shape feel like they are moving in two directions. The message composer got taller, while the user messages got more tightly wrapped. I think it would feel more coherent if everything moved in the same direction: more or less padding, more or less boxy. I think I would prefer more horizontal padding and slightly boxier. I like how Posit Assistant's user messages feel, which I think have more horizontal padding than shinychat's.

  • The chat composer feels somewhat too tall and clunky, caught between the more compact shinychat pill version and a more expansive, boxier feel. I think it should just move slightly in either direction to feel more intentional.
  • The send message button still feels very shinychat-like and prominent to me. What do you think about making it hollow, like Posit Assistant?
  • Changing the user message background color might also help it feel less default-shinychat. It could stay gray, but be a different shade, possibly a light blue-gray? I don't feel strongly about this.

@skaltman

Copy link
Copy Markdown
Collaborator

Also, do you think that the send-button spinner is necessary? Could the send button just be disabled and gray during that period instead? This might fall under shinychat work, though.

@simonpcouch

Copy link
Copy Markdown
Collaborator Author

Here's another take on those shapes!

Screenshot 2026-08-21 at 1 35 27 PM

The default shinychat color is actually a light blue and we had changed it to a light grey. Here's the default blue with the new geometry:

Screenshot 2026-08-21 at 1 37 16 PM

I actually think the default shinychat blue looks fine here!

@skaltman

Copy link
Copy Markdown
Collaborator

This looks nice! I like the shapes in this version

@simonpcouch

Copy link
Copy Markdown
Collaborator Author

@gadenbuie, do you mind to take a look here and share any reactions? Did my best not to overlap with page_chat() changes and broadly not step on internal shinychat toes.

The "Working..." change specifically might be of interest for shinychat, as an alternative to the spinner icon. The implementation on the shinychat side could be cleaner than the one here, where we use a constant delay to avoid a flicker.

Comment thread pkg-r/inst/www/commons-chat/commons-chat.css Outdated
Comment thread pkg-r/inst/www/commons-chat/commons-chat.css
@gadenbuie

Copy link
Copy Markdown
Collaborator

I fixed the missing visual feedback in shinychat when waiting for the API response to start streaming in when you don't have an icon, although I went a slightly different direction that re-uses some existing shinychat design. Also the assistant icon is now disabled by default in dev shinychat

@simonpcouch

Copy link
Copy Markdown
Collaborator Author

Thank you @gadenbuie! Had just been poking at this again but will wait and see how posit-dev/shinychat#341 comes together before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make commons_ui() feel more like a modern chat app

3 participants