Repository navigation
Conversation
This was referenced Oct 12, 2026
cpsievert
force-pushed
the
feat/maps-capability-r
branch
from
October 13, 2026 15:10
3de5ada to
4bafa97
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R side of the opt-in
"maps"capability (sibling to #323 for Python; spec in localdocs/superpowers/specs/2026-10-12-maps-capability-design.md).Included here:
tools = c("default", "maps")."default"expands to the default tool set (also fixes the existing "must restate every tool to add one" problem);"maps"is a capability modifier that aborts with a clear error if"visualize"is absent, and is dropped alongside"visualize"when the ggsql package is missing.ggsql-spatial.mdpartial (byte-identical to the Python copy) renders only when maps is enabled. It teaches theggsql:worldchoropleth-join pattern, lon/lat point maps, named projections, and guardrails.Not included yet (needs the in-progress R caching-reader work, which is currently uncommitted in a local checkout of
ggsql-caching-reader-r): the spatial-extension pre-warm inviz_caching_reader()and spatial error translation in the viz tool. Until those land, enabling maps gives the LLM spatial guidance but queries fail with ggsql's raw extension error — so do not merge before that follow-up. One open dependency for the follow-up: the extension install location must respect CRAN policy (a user cache dir rather than~/.duckdb), which may need a small ggsql-r hook.Verification
normalize_toolssentinel expansion and maps-requires-visualize error,check_viz_depsdropping maps, prompt rendering with/without maps.devtools::test(filter = "QueryChat")andfilter = "QueryChatSystemPrompt": 0 failures.