Feat: Added extra argument and test for the save option for text files - #9142
Pranava-Pai-N wants to merge 5 commits into
Conversation
perminder-17
left a comment
There was a problem hiding this comment.
Hi, thanks for contributing!
Could you please provide a little more context about the issue? I just came across it, but I’m not fully clear on what was missing and how this PR fixes the issue.
|
Hi @perminder-17 , thank you for the review and the doubt regarding the PR : The main consequence is that text files saved via save() would always use \n line endings, even when the caller explicitly asked for CRLF (true). That can cause Windows-style line-ending expectations to fail, especially when files are opened or processed by tools that rely on \r\n for compatibility. |
Resolves #9141
Changes:
Added third argument for saving txt files along with the required tests
PR Checklist
npm run lintpasses