Skip to content

Feat: Added extra argument and test for the save option for text files #9142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pranava-Pai-N wants to merge 9 commits into
base: main
Choose a base branch
from
+25 −3
Open

Feat: Added extra argument and test for the save option for text files #9142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4c7a7d6
Feat: Added extra argument and test for the save option for text files
Pranava-Pai-N Sep 5, 2026
2b8106a
Merge branch 'main' into feat/save-clrf
Pranava-Pai-N Sep 7, 2026
276051f
Merge branch 'main' into feat/save-clrf
Pranava-Pai-N Sep 8, 2026
8edcd04
Merge branch 'main' into feat/save-clrf
Pranava-Pai-N Sep 13, 2026
7a1ecde
Merge branch 'main' into feat/save-clrf
Pranava-Pai-N Sep 16, 2026
2e331fd
Fix: Added an extra argument for txt files for windows along with the…
Pranava-Pai-N Sep 19, 2026
a1e3102
Merge branch 'feat/save-clrf' of https://github.com/Pranava-Pai-N/p5.…
Pranava-Pai-N Sep 19, 2026
ba4b3cc
Merge branch 'main' into feat/save-clrf
Pranava-Pai-N Sep 19, 2026
3474203
Feat: Removed fourth parameter for save as per the maintainer request…
Pranava-Pai-N Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/io/files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1669,13 +1669,13 @@ function files(p5, fn) {
fn.saveJSON(args[0], args[1], args[2]);
return;
case 'txt':
fn.saveStrings(args[0], args[1], args[2]);
fn.saveStrings(args[0], args[1], 'txt', args[2]);
return;
// =================================================
// OPTION 3: decide based on object...
default:
if (args[0] instanceof Array) {
fn.saveStrings(args[0], args[1], args[2]);
fn.saveStrings(args[0], args[1], undefined, args[2]);
} else if (args[0] instanceof p5.Table) {
fn.saveTable(args[0], args[1], args[2]);
} else if (args[0] instanceof p5.Image) {
Expand Down
24 changes: 23 additions & 1 deletion test/unit/io/files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { vi } from 'vitest';
const mockAnchorElement = vi.mockObject({
href: null,
download: null,
click: () => {}
click: () => { }
});
const originalCreateElement = document.createElement;
vi.spyOn(document, 'createElement').mockImplementation((...args) => {
Expand Down Expand Up @@ -191,6 +191,28 @@ suite('Files', function () {
assert.equal(mockAnchorElement.download, 'filename.txt');
});

test('should preserve CRLF when saving a text file without an extension', async () => {
const myStrings = ['aaa', 'bbb'];
mockP5Prototype.save(myStrings, 'filename', true);

const saveData = new Blob([myStrings.join('\r\n')]);
expect(document.createElement).toHaveBeenCalledTimes(1);
expect(mockAnchorElement.click).toHaveBeenCalledTimes(1);
expect(URL.createObjectURL).toHaveBeenCalledWith(saveData);
assert.equal(mockAnchorElement.download, 'filename.txt');
});

test('should preserve CRLF when saving a text file', async () => {
const myStrings = ['aaa', 'bbb'];
mockP5Prototype.save(myStrings, 'filename.txt', true);

const saveData = new Blob([myStrings.join('\r\n')]);
expect(document.createElement).toHaveBeenCalledTimes(1);
expect(mockAnchorElement.click).toHaveBeenCalledTimes(1);
expect(URL.createObjectURL).toHaveBeenCalledWith(saveData);
assert.equal(mockAnchorElement.download, 'filename.txt');
});

test('should download a json file', async () => {
const myObj = { hi: 'hello' };
mockP5Prototype.save(myObj, 'filename.json');
Expand Down