Skip to content

Desktop: files from disk are still watched after a restart (v0.25.2) - #66

Merged
ralyodio merged 1 commit into
mainfrom
fix/desktop-stale-disk-files
Oct 28, 2026
Merged

ralyodio merged 1 commit into
mainfrom
fix/desktop-stale-disk-files

Conversation

@ralyodio

Copy link
Copy Markdown
Contributor

A desktop file handle could not be stored, so after a relaunch every file the app had opened from disk fell back to its stored copy: a save in another editor (Sublime, ~/Desktop/list.txt) never reloaded and never synced. 0.25.0 watched every file, but only within one run.

  • desktop 0.19.0 keeps the paths it opened in userData/opened.json (capped at 200k) and answers reopen-files with the ones still on disk; still only paths the person opened.
  • the page stores each desktop file path + last-seen fingerprint, restores the handles on launch, and checks all disk files right away.
  • regression test: open list.txt, quit, change it on disk, relaunch: the new text loads (fails on main).

🤖 Generated with Claude Code

A desktop file's handle cannot be stored, so after relaunching the app every file it had
opened from disk lost its disk link and the stored copy won: ~/Desktop/list.txt saved in
Sublime stayed old in readm3 and never synced. The desktop app (0.19.0) now keeps the paths
it opened in userData and hands back the ones still there (reopen-files); the page stores
each desktop file's path and last-seen fingerprint, restores the handles on launch and
checks every file at once.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ralyodio
ralyodio merged commit 7263b89 into main Oct 28, 2026
14 checks passed
ralyodio added a commit that referenced this pull request Oct 28, 2026
…open the folder again" (v0.26.2) (#70)

Anthony: "syncing still broken: That stored file chunk is not here. i get this a
lot now. and it says to re-open the folder, why do we have to do that?"

Large files, PDFs and images the desktop app reads from disk had a reader for one
session only. #66 restored the disk handles after a restart but not these readers,
so after relaunching the desktop could not open them ("Open its folder again"),
sync could not upload them, and the account held references with no bytes: the web
editor's "That stored file chunk is not here".

- Every stored file with a restored disk handle gets its reader back on launch and
  after each sync, so it opens and the next sync uploads what the account lacks.
- A file changed on disk to another size is skipped for that upload instead of
  stopping the whole pass on the server's chunk-size check.
- A stored file the account does not hold yet says so in words; "open the folder"
  is left only for a file that moved or was deleted on disk.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant