Skip to content

feat: short config_inputs labels, explanations in help (needs protoAgent#3631 released) - #3

Merged
mabry1985 merged 4 commits into
mainfrom
feat/config-inputs-help
Sep 26, 2026
Merged

mabry1985 merged 4 commits into
mainfrom
feat/config-inputs-help

Conversation

@mabry1985

@mabry1985 mabry1985 commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

What

The Engineer's two config_inputs rendered as long paragraph labels in the create-time setup form. Labels are now short, with the explanation in the new optional help: line:

key label help
terminal.cwd (path, project) Start in a local repo Registered as a managed project the agent can reach, and the terminal opens there.
github.write (boolean, default false) Allow GitHub writes Lets the agent open, comment on, label and merge issues and PRs when you ask. Off = read-only.

README "First run" / GitHub-writes wording updated to match. Merged main in (terminal v0.9.0 + terminal.agent_access: read from #4 are kept).

Core floor

help renders on protoAgent ≥ 0.183.0 (protoLabsAI/protoAgent#3631, released in v0.183.0). It's backward compatible: older cores ignore help and show just the short label. verified_against is bumped to 0.183.0, and the floor is stated in the manifest's CORE FLOOR comment and the README.

🤖 Generated with Claude Code

"A local repo to start in (absolute path; optional — it is registered as a project and
the terminal opens there)" and "Let the agent write to GitHub when you ask (…). Off =
read-only" rendered as long paragraph labels in the set-up step. The labels are now
"Start in a local repo" / "Allow GitHub writes", with the explanations moved to the
new optional `help:` line (protoLabsAI/protoAgent#3631).

Backward compatible: cores that predate `help` ignore it and show the short label.
Hold the merge/tag until the core release carrying #3631 ships.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@mabry1985
mabry1985 marked this pull request as draft September 26, 2026 06:29

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA panel review — WARN

code-review · head a1c8dadcd1c2 · formal

Low-risk PR: a label/help-text rename and a README wording change. The one thing worth fixing before merge is the loss of the "absolute path" hint on the terminal.cwd field — if the core's path picker doesn't enforce it, users will hit a confusing failure with no prior warning. The panel agreed on both findings; verification confirmed both with no disputes. No coverage gaps: the diff is small and fully covered by the cross-file and conventions lanes.

Findings

Severity Location Finding Verified
🟡 minor protoagent.bundle.yaml:87 The 'absolute path' constraint on terminal.cwd was removed from both the form label and the README, replaced with the vaguer 'a folder on the agent's machine';… confirmed
🟡 minor protoagent.bundle.yaml:133 The rename from 'Configure' to 'set-up' was applied to the labels and header comments but this comment still references the old 'Configure toggle', which no lo… confirmed
findings JSON (machine-readable)
[
  {
    "file": "protoagent.bundle.yaml",
    "line": 87,
    "severity": "minor",
    "category": "removed-behavior",
    "claim": "The 'absolute path' constraint on terminal.cwd was removed from both the form label and the README, replaced with the vaguer 'a folder on the agent's machine'; if the core's type:path picker does not itself enforce absolute paths, users who enter a relative or home-relative path will get a confusing failure with no prior warning.",
    "evidence": "Old label: \"A local repo to start in (absolute path; optional \u2014 it is registered as a project and the terminal opens there)\" \u2192 New label: \"Start in a local repo\" with help: \"Registered as a managed project the agent can reach, and the terminal opens there.\" Neither mentions the absolute-path requirement. README: \"(an absolute path)\" \u2192 \"(a folder on the agent's machine)\".",
    "verdict": "confirmed",
    "note": "Diff clearly shows the old label contained '(absolute path; optional\u2026)' and the new label/help omit it; README diff shows '(an absolute path)' \u2192 '(a folder on the agent's machine)'. The conditional about the core's path picker is speculative but the factual removal is accurate."
  },
  {
    "file": "protoagent.bundle.yaml",
    "line": 133,
    "severity": "minor",
    "category": "conventions",
    "claim": "The rename from 'Configure' to 'set-up' was applied to the labels and header comments but this comment still references the old 'Configure toggle', which no longer matches the 'Allow GitHub writes' label in the set-up step it points to. Flagged by both cross-file and conventions review.",
    "evidence": "# Configure toggle above, or Settings \u25b8 GitHub) binds the write tools for when you ask.",
    "verdict": "confirmed",
    "note": "File at PR head (line ~135) still reads 'Configure toggle above' while the step is now called 'set-up' and the label is 'Allow GitHub writes'. Stale reference confirmed; line number is off by ~2 but substance is correct."
  }
]

@mabry1985
mabry1985 marked this pull request as ready for review September 26, 2026 08:37

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA panel review — WARN

code-review · head 692b13bf663e · formal

Low-risk rename-and-copyedit PR. The one thing to fix first is the stale "Configure toggle" comment at line 131 — it's a one-word fix that closes the last gap in the rename. The panel agreed on both findings; no disagreement. Verification confirmed both and added no new items. The "absolute path" finding is a copy-edit gap (the constraint was dropped from user-facing text) rather than a functional defect, so it's minor.

Findings

Severity Location Finding Verified
🟡 minor protoagent.bundle.yaml:131 The rename from "Configure" to "set-up" was applied throughout the file except this comment, which still reads "Configure toggle" — flagged by both correctness… confirmed
🟡 minor protoagent.bundle.yaml:87 The explicit "absolute path" constraint on terminal.cwd was removed from both the form label and the README, replaced with the vaguer "a folder on the agent's … confirmed
findings JSON (machine-readable)
[
  {
    "file": "protoagent.bundle.yaml",
    "line": 131,
    "severity": "minor",
    "category": "conventions",
    "claim": "The rename from \"Configure\" to \"set-up\" was applied throughout the file except this comment, which still reads \"Configure toggle\" \u2014 flagged by both correctness and conventions review.",
    "evidence": "# Configure toggle above, or Settings \u25b8 GitHub) binds the write tools for when you ask.",
    "verdict": "confirmed",
    "note": "Verified at PR head: the comment in the github config block still says 'Configure toggle' while the rest of the file uses 'set-up' (e.g. 'two optional set-up answers', 'the set-up step in the Setup Wizard')."
  },
  {
    "file": "protoagent.bundle.yaml",
    "line": 87,
    "severity": "minor",
    "category": "removed-behavior",
    "claim": "The explicit \"absolute path\" constraint on terminal.cwd was removed from both the form label and the README, replaced with the vaguer \"a folder on the agent's machine\"; if the core's type:path picker does not itself enforce absolute paths, users entering a relative path will get a confusing failure with no prior warning.",
    "evidence": "Old label: \"A local repo to start in (absolute path; optional \u2014 it is registered as a project and the terminal opens there)\" \u2192 New label: \"Start in a local repo\" with help: \"Registered as a managed project the agent can reach, and the terminal opens there.\" Neither mentions the absolute-path requirement. README: \"(an absolute path)\" \u2192 \"(a folder on the agent's machine)\".",
    "verdict": "confirmed",
    "note": "Diff confirms the old label explicitly said 'absolute path' and the new label/help do not; README diff confirms '(an absolute path)' \u2192 '(a folder on the agent's machine)'. The speculative clause about the picker not enforcing it is reasonable but unverifiable from this repo alone \u2014 the factual text-change claims are solid."
  }
]

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA panel review — WARN

code-review · head a7851d7f653f · formal

Low-risk change: the PR simplifies the terminal.cwd form label and its README description, dropping the explicit "absolute path" constraint in favor of vaguer language. The one surviving finding (minor, conventions) notes that if the core's type: path picker does not itself enforce absolute paths, users entering a relative path will hit a confusing failure with no prior warning. The verifier confirmed the factual basis (the constraint is indeed absent from both new surfaces) while flagging the conditional about core picker behavior as unverifiable from this repo. No panel disagreement; no coverage gaps.

Findings

Severity Location Finding Verified
🟡 minor protoagent.bundle.yaml:87 The explicit "absolute path" constraint on terminal.cwd was removed from both the form label and the README, replaced with the vaguer "a folder on the agent's … confirmed
findings JSON (machine-readable)
[
  {
    "file": "protoagent.bundle.yaml",
    "line": 87,
    "severity": "minor",
    "category": "conventions",
    "claim": "The explicit \"absolute path\" constraint on terminal.cwd was removed from both the form label and the README, replaced with the vaguer \"a folder on the agent's machine\"; if the core's type:path picker does not itself enforce absolute paths, users entering a relative path will get a confusing failure with no prior warning.",
    "evidence": "Old label: \"A local repo to start in (absolute path; optional \u2014 it is registered as a project and the terminal opens there)\" \u2192 New label: \"Start in a local repo\" with help: \"Registered as a managed project the agent can reach, and the terminal opens there.\" Neither mentions the absolute-path requirement. README: \"(an absolute path)\" \u2192 \"(a folder on the agent's machine)\".",
    "verdict": "confirmed",
    "note": "Diff shows exactly the old\u2192new label/help and README text quoted; the 'absolute path' constraint is absent from both new surfaces. The conditional about the core picker's enforcement is unverifiable from this repo but the factual basis is solid."
  }
]

@mabry1985
mabry1985 merged commit b551370 into main Sep 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant