Repository navigation
fix(health): a cut-short structural pass is not a structural outage - #117
Merged
Merged
Conversation
The 6 h window counted every `structural_unavailable` row as "structural_out" and alarmed on them as "structural lane unavailable" — but pr-reviewer stamps that flag on feature-cap / budget partials too (rows before plugin#274), so a pass that ran and kept its findings read as protoPatch being down. Outages are now `structural_unavailable and not structural_partial` (correct for both row shapes); the incomplete-lane tally still names find_structural for either. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![protoreview[bot]](https://avatars.githubusercontent.com/in/4233969?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA panel review — PASS
code-review · head 421e7c693904 · formal
All four finders independently reviewed the diff and found no defects; the verifier confirmed there was nothing to verify. No panel disagreement, no coverage gaps, no findings to carry forward. This is a clean pass.
No findings — the review came back clean.
findings JSON (machine-readable)
[]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to protoLabsAI/pr-reviewer-plugin#275, which fixes #274.
window_healthcounted everystructural_unavailablerow asstructural_outand alarmed as "structural lane unavailable on N rounds". pr-reviewer also sets that flag on feature-cap and budget partials, in rows written before #274, so a capped pass that ran and kept its findings was counted as protoPatch being down.structural_unavailable and not structural_partial. That's correct for both the old row shape (both flags) and the new one (structural_partialalone).find_structuralfor either flag.Tests: 53 passed, including two new ones for the partial row shapes.
🤖 Generated with Claude Code