Skip to content

Vulkan: halve the pointwise conv spatial tile #22781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msluszniak wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Vulkan: halve the pointwise conv spatial tile #22781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backends/vulkan/runtime/graph/ops/glsl/conv2d_pw_tiled.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ conv2d_pw_tiled:
TILE_M4: 1
TILE_K4: 1
TILE_N4: 1
TILE_M: 4
TILE_M: 2
generate_variant_forall:
DTYPE:
- VALUE: float
Expand Down
4 changes: 2 additions & 2 deletions backends/vulkan/runtime/graph/ops/impl/Conv2dPW.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ GlobalWorkGrid pick_conv2d_pw_tiled_gwg(
uint32_t C_out = graph->size_at<uint32_t>(-3, out);
uint32_t M = H * W;
uint32_t N4 = utils::div_up_4(C_out);
// TILE_N4=1, TILE_M=4
return GlobalWorkGrid({N4, utils::div_up(M, 4u), 1u}, kTiledWorkGrid);
// TILE_N4=1, TILE_M=2. Must match conv2d_pw_tiled.yaml.
return GlobalWorkGrid({N4, utils::div_up(M, 2u), 1u}, kTiledWorkGrid);
}

//
Expand Down
Loading