Skip to content

Align theme filenames and selectors with iOS 27 - #144

Merged
rdlabo merged 7 commits into
mainfrom
refactor/ios27-naming
Sep 10, 2026
Merged

Align theme filenames and selectors with iOS 27#144
rdlabo merged 7 commits into
mainfrom
refactor/ios27-naming

Conversation

@rdlabo

@rdlabo rdlabo commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

The iOS 27 package still exposed iOS 26 stylesheet filenames and selectors. Rename the stylesheet entry points to ionic-theme-ios27* and align CSS variables, classes, animation identifiers, demo imports, and documentation.

Consumers must update old stylesheet paths. CSS variables now use the version-independent --ios-theme-* prefix, with corresponding --ios26-* names retained as deprecated fallbacks. New names take precedence when both are set; the migration guide describes the naming changes. The version-independent ios-theme-disabled class is now the documented opt-out. ios26-disabled remains supported as a deprecated alias in styles and animations; ios27-disabled is not introduced. References that maintain the legacy ios26 branch and deployments remain intact. Remove the unused SwiftUI comparison project and rename the archived screenshot.

Validation: library build, demo production build, Prettier, and diff checks passed. The demo build retains existing browser-support, unused-import, and bundle-budget warnings. Browser verification confirmed identical header/back-button transition opt-outs for both supported class names, including coexistence with a regular button. Browser verification also confirmed element-level legacy CSS variable values, new-name precedence, and restoration of the fallback when the new value is unset. Screenshot baselines were not regenerated in this change.

Document adaptive iOS 26/27 loading in docs/ios-adaptive.md, using mutually exclusive CSS feature queries and matching dynamic animation imports. Correct the demo directory diagram. Both Sass examples were compiled against the corresponding theme sources.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Devin Review

Comment thread docs/ios-18.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 iOS 18 向け説明に旧バージョンが残っています

例は iOS 27 に更新済みですが、本文は「iOS 26 の端末だけで読み込む」と説明しています。対象 OS の記述を確認してください。

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment thread demo/README.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 デモの構成図が存在しないテーマファイルを案内しています

構成図は demo/src/theme/theme-ios27.scss を示しますが、そのファイルは存在しません。実際のテーマ読み込み先に合わせて更新してください。

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Playwright test results

passed  90 passed

Details

stats  90 tests across 2 suites
duration  1 minute, 42 seconds
commit  2ae521f
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

github-actions Bot added a commit that referenced this pull request Sep 10, 2026
github-actions Bot added a commit that referenced this pull request Sep 10, 2026
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-144/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 10, 2026
@rdlabo
rdlabo merged commit 7503844 into main Sep 10, 2026
11 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

npm beta published

CI passed for the merge commit 75038445db78. Install the immutable version with:

npm install @rdlabo/ionic-theme-ios27@0.1.0-beta.pr144.sha75038445db78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant