Align theme filenames and selectors with iOS 27 - #144
Merged
Conversation
Contributor
Contributor
Contributor
Playwright test resultsDetails
|
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-144/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
Contributor
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-ios27@0.1.0-beta.pr144.sha75038445db78 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iOS 27 package still exposed iOS 26 stylesheet filenames and selectors. Rename the stylesheet entry points to
ionic-theme-ios27*and align CSS variables, classes, animation identifiers, demo imports, and documentation.Consumers must update old stylesheet paths. CSS variables now use the version-independent
--ios-theme-*prefix, with corresponding--ios26-*names retained as deprecated fallbacks. New names take precedence when both are set; the migration guide describes the naming changes. The version-independentios-theme-disabledclass is now the documented opt-out.ios26-disabledremains supported as a deprecated alias in styles and animations;ios27-disabledis not introduced. References that maintain the legacyios26branch and deployments remain intact. Remove the unused SwiftUI comparison project and rename the archived screenshot.Validation: library build, demo production build, Prettier, and diff checks passed. The demo build retains existing browser-support, unused-import, and bundle-budget warnings. Browser verification confirmed identical header/back-button transition opt-outs for both supported class names, including coexistence with a regular button. Browser verification also confirmed element-level legacy CSS variable values, new-name precedence, and restoration of the fallback when the new value is unset. Screenshot baselines were not regenerated in this change.
Document adaptive iOS 26/27 loading in
docs/ios-adaptive.md, using mutually exclusive CSS feature queries and matching dynamic animation imports. Correct the demo directory diagram. Both Sass examples were compiled against the corresponding theme sources.