Radar: fix the Helm install steps and list container images per release - #4014
Open
EliShteinman wants to merge 12 commits into
Open
EliShteinman wants to merge 12 commits into
EliShteinman wants to merge 12 commits into
Conversation
Add a Downloads section to the 2026.9.2 and 2026.9.5 release notes, taken from each chart's rendered defaults, so air-gapped installs know exactly which images to mirror for the version they install. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The index still said "and the Helm chart" with no source, and did not say where per-release images are listed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Step 1 created secrets in the radar namespace, which only came into being at helm install --create-namespace, so kubectl create secret failed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
With an external database the chart fails to render without database.host
("database.host is required when postgresql.enabled is false"); its
wait-for-db init containers probe that host. Both documented commands hit it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Unquoted ingress.hosts[0]... is a glob in zsh, the macOS default shell: "zsh: no matches found". Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Install a named release so the chart and the images mirrored for it match, and point to the per-release Downloads lists. Replace the source-checkout path, which refers to a repository customers cannot access, with the chart package file. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The chart pulls redislabs/radar:{app,worker,migrate}-v<version>, not
radar-app/radar-worker/radar-migrate. global.imageRegistry does not reach
those images (image.registry defaults to docker.io and wins) or busybox (no
registry key), so the documented override pulled everything from Docker
Hub. Verified by rendering charts 2026.9.2 and 2026.9.5 in both database
modes. Compose names are left as documented; the bundle was not available
to check.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
With an external database the job is a Helm hook with hook-succeeded deletion, so a successful install leaves no job to list. With bundled PostgreSQL it is a kept resource with a 7-day TTL. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…d Helm Kubernetes and OpenShift nodes run containerd or CRI-O, not Docker, and the images.tar.gz bundle is not published anywhere customers can download it. Document the path that works with public artifacts: helm pull the chart, copy the per-release images into a registry, install from the package. skopeo --all keeps multi-platform busybox intact when copying from an arm64 workstation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The authenticated-mirror helm test path and checksum guidance still need correction.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates Radar Helm installation documentation and release notes to match published charts, images, and air-gapped workflows.
Changes:
- Fixes namespace, database host, version pinning, quoting, and migration verification guidance.
- Adds per-release chart and container image inventories.
- Replaces inaccurate air-gapped Helm instructions with chart mirroring steps.
File summaries
| File | Summary |
|---|---|
content/operate/radar/install.md |
Corrects Helm and air-gapped installation procedures. |
content/operate/radar/release-notes/2026-9-2.md |
Adds release-specific download information. |
content/operate/radar/release-notes/2026-9-5.md |
Adds release-specific download information. |
content/operate/radar/release-notes/_index.md |
Links the Helm repository and release downloads. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The chart's test pod renders no imagePullSecrets and runs as the default service account, so link the pull secret there. oc secrets link appends rather than replacing OpenShift's generated dockercfg secret. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
A chart fetched with helm pull comes without a checksum file, so the unconditional sha256sum step blocked the Helm air-gapped path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the Helm steps on the Radar install page as written fails. I checked each Helm claim against the published charts 2026.9.2 and 2026.9.5 from
https://helm.redis.io/radar, usinghelm templatein both database modes, and against Docker Hub.What was wrong
helm installcommandsdatabase.host is required when postgresql.enabled is false. The chart'swait-for-dbinit containers probe that host.radarnamespace, which only existed afterhelm install --create-namespace.--set ingress.hosts[0]...zsh: no matches found.radar-app,radar-worker, andradar-migrate. The chart pullsredislabs/radar:{app,worker,migrate}-v<version>, the only Radar repository on Docker Hub.redislabs/radar-appand the others don't exist.global.imageRegistrydoes not reach the Radar images:image.registrydefaults todocker.ioand takes precedence. It also does not reachbusybox, which has no registry key. With the documented values, every Radar image still comes from Docker Hub. Chart issue: RedisLabs/redis-enterprise-helm#101.hook-succeededdeletion, so a successful install leaves no job to list.docker loadonto the nodes doesn't apply to Kubernetes or OpenShift nodes, which run containerd or CRI-O. Theimages.tar.gzbundle it relies on is not published in the Download Center, on Docker Hub, or in the Helm repository../helm/radarrefers to a repository customers can't access.What changed
## Downloadssection, following the Kubernetes release notes convention, with the chart version and every container image that release's chart renders. That includesbusyboxand the optional bundled PostgreSQL. The images arelinux/amd64only, and the section says so. Each version's page now lists exactly what to mirror for that version.database.hostto both install commands.--setvalues.--version <version>in the commands and points to the per-release Downloads lists.image.registry, and a registry-qualifieddbWaitInitContainer.image.repository.helm testpullbusyboxfrom an authenticated mirror. The chart's test pod gets noglobal.imagePullSecretsand runs as thedefaultservice account.helm pullthe chart package, copy the listed images into a registry withskopeo copy --all, then install from the package.--allmatters for multi-platformbusyboxwhen copying from an arm64 workstation.Verification
tar -xzf radar-<version>.tgz radar/values-openshift.yamlproduces the path the OpenShift command expects.content/operate/radarand no broken references.Left unchanged, needs product input
images.tar.gzbundle, andradar-v<version>.SHA256SUMS. I couldn't find these published anywhere, so I couldn't verify them. The Compose image names are left as documented. Thesha256sum -cstep now applies only when the transferred artifacts include that file, since a chart fetched withhelm pullhas none.postgresql.enabled,auth.password,auth.postgresPassword, and--wait --wait-for-jobs. They aren't documented on this page.externalCertificate. See radar: values-openshift.yaml does not cover an air-gapped install (images to mirror, Route TLS) RedisLabs/redis-enterprise-helm#102.🤖 Generated with Claude Code