Repository navigation
Conversation
Related to repeat98#662. With Euclidean open, TRIG, SRC, FLTR, AMP and LFO did nothing; only NO closed it. FUNC + FLTR and FUNC + LFO changed the header underneath while the Euclidean controls stayed on screen. These keys now close Euclidean and pass the same press to the parameter page, as from any native page. FUNC + SRC has no native action and keeps Euclidean open. Source pinned to sumedho/digirequests 27432d5. Emulator page-key regression on OS 1.53 and 1.54; author hardware test on both OSes with all six mods and alone, including project save/reload and a power cycle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #662.
What was wrong
With Euclidean open (long FUNC + AMP), TRIG, SRC, FLTR, AMP and LFO did nothing; only NO left the page. The Euclidean page is a modal over the parameter page, and its key handler passed those keys to a generic view handler that does not switch pages. FUNC + FLTR and FUNC + LFO changed the header underneath to Delay or Compressor while the Euclidean controls stayed on screen.
Fix (1.1.5)
These keys now close Euclidean and pass the same press to the parameter page underneath, as from any native page: TRIG, SRC, FLTR, AMP, LFO, and FUNC + TRIG / FLTR / AMP / LFO (Quantize, Delay, Reverb, Compressor). FUNC + SRC has no native action and keeps Euclidean open. Holding FUNC + AMP from Euclidean closes and reopens it. The only source change is the key handler in
src/release-153/page.candsrc/release-154/page.c(source: sumedho/digirequests27432d5).Evidence
evidence/page-keys-1.1.5.json): on a MIDI and an audio track, each of the ten combinations is applied natively as a reference, then pressed with Euclidean open; Euclidean must close and the LCD must match. 1.1.4 fails at the first check; 1.1.5 passes 233 checks on OS 1.53 and 1.54, standalone and with all six mods. The earlier Euclidean UI, editing and playback regressions keep their 1.1.4 pass counts; both all-mods SysEx cold-boot.evidence/modwerk-source-parity.json): Modwerk's compile links all 126 feature selections (63 per OS) to the native MAIN byte for byte, through Modwerk, reversed order, the browser kit and the native objects. The conflicts Modwerk main added in Improvement: catch module collisions before submission #629 (cc-names, note-accumulator, ram-machines, sample-tools) were copied into the native reference first; they are metadata and do not change any image. Locally rebuilt 1.1.4 packages reproduce the published ones byte for byte with the same GCC 16.2 toolchain.Scope
Module folder, its changelog, the source-only package record and packages, and the module's own browser-catalogue record (
elekloader-euclidean-2026-10-16.json, moved from-2026-10-14) with the vendored 1.1.5 packages.elekloader:updatesuggests adocs/VERIFICATION.mdnote; it is left out to keep this a module-only release.npm run checkpasses;pr:readyreports only that sumedho is not a registered automatic-release author, so this needs owner review as #575 did.🤖 Generated with Claude Code