Skip to content

Euclidean Sequencing 1.1.5: page keys leave the Euclidean page - #675

Open
sumedho wants to merge 5 commits into
repeat98:mainfrom
sumedho:digitakt-euclidean-1.1.5
Open

sumedho wants to merge 5 commits into
repeat98:mainfrom
sumedho:digitakt-euclidean-1.1.5

Conversation

@sumedho

@sumedho sumedho commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Related to #662.

What was wrong

With Euclidean open (long FUNC + AMP), TRIG, SRC, FLTR, AMP and LFO did nothing; only NO left the page. The Euclidean page is a modal over the parameter page, and its key handler passed those keys to a generic view handler that does not switch pages. FUNC + FLTR and FUNC + LFO changed the header underneath to Delay or Compressor while the Euclidean controls stayed on screen.

Fix (1.1.5)

These keys now close Euclidean and pass the same press to the parameter page underneath, as from any native page: TRIG, SRC, FLTR, AMP, LFO, and FUNC + TRIG / FLTR / AMP / LFO (Quantize, Delay, Reverb, Compressor). FUNC + SRC has no native action and keeps Euclidean open. Holding FUNC + AMP from Euclidean closes and reopens it. The only source change is the key handler in src/release-153/page.c and src/release-154/page.c (source: sumedho/digirequests 27432d5).

Evidence

  • Emulator page-key regression (evidence/page-keys-1.1.5.json): on a MIDI and an audio track, each of the ten combinations is applied natively as a reference, then pressed with Euclidean open; Euclidean must close and the LCD must match. 1.1.4 fails at the first check; 1.1.5 passes 233 checks on OS 1.53 and 1.54, standalone and with all six mods. The earlier Euclidean UI, editing and playback regressions keep their 1.1.4 pass counts; both all-mods SysEx cold-boot.
  • Source parity (evidence/modwerk-source-parity.json): Modwerk's compile links all 126 feature selections (63 per OS) to the native MAIN byte for byte, through Modwerk, reversed order, the browser kit and the native objects. The conflicts Modwerk main added in Improvement: catch module collisions before submission #629 (cc-names, note-accumulator, ram-machines, sample-tools) were copied into the native reference first; they are metadata and do not change any image. Locally rebuilt 1.1.4 packages reproduce the published ones byte for byte with the same GCC 16.2 toolchain.
  • Hardware (author, Digitakt 1, 2026-10-16, under 30 minutes): OS 1.53 and 1.54, with all six mods and with Euclidean alone. Page keys and FUNC shortcuts leave Euclidean on audio and MIDI tracks, FUNC + AMP reopens it, and settings survived project save/reload and a power cycle. No failures reported. Tested SysEx hashes are in TESTING.md.
  • Screenshots recaptured from the 1.1.5 images; they are pixel-identical to 1.1.4's.

Scope

Module folder, its changelog, the source-only package record and packages, and the module's own browser-catalogue record (elekloader-euclidean-2026-10-16.json, moved from -2026-10-14) with the vendored 1.1.5 packages. elekloader:update suggests a docs/VERIFICATION.md note; it is left out to keep this a module-only release. npm run check passes; pr:ready reports only that sumedho is not a registered automatic-release author, so this needs owner review as #575 did.

  • Automatically merge and publish my module update after checks pass.
  • I verified the source, licences, UI and qualification reports, including instance isolation and Part/project/reboot persistence where applicable; no required acceptance check is failed or untested.

🤖 Generated with Claude Code

sumedho and others added 4 commits October 16, 2026 16:12
Related to repeat98#662. With Euclidean open, TRIG, SRC, FLTR, AMP and LFO did
nothing; only NO closed it. FUNC + FLTR and FUNC + LFO changed the header
underneath while the Euclidean controls stayed on screen. These keys now
close Euclidean and pass the same press to the parameter page, as from any
native page. FUNC + SRC has no native action and keeps Euclidean open.

Source pinned to sumedho/digirequests 27432d5. Emulator page-key
regression on OS 1.53 and 1.54; author hardware test on both OSes with all
six mods and alone, including project save/reload and a power cycle.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant