Repository navigation
Rename Rust client stop functions - #1456
Merged
Merged
Conversation
Contributor
Author
|
Failure fixed in #1457. |
Just before we hit a release, bring Rust more inline naming-wise with other libraries: * `shutdown` -> `stop` * `shutdown_now` -> `stop_and_cancel` IMO, the shorter name is a little better anyway, but it's particularly better because when sorting alphabetically, "shutdown" appears before "start", whereas "stop" appears after, giving you a more logical ordering as you're perusing code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just before we hit a release, bring Rust more inline naming-wise with
other libraries:
shutdown->stopshutdown_now->stop_and_cancelIMO, the shorter name is a little better anyway, but it's particularly
better because when sorting alphabetically, "shutdown" appears before
"start", whereas "stop" appears after, giving you a more logical
ordering as you're perusing code.