[cmake] Do not auto-turn OFF feature or auto-turn ON builtin_option

[ferdymercury]

for easy-to-install dependencies (via homebrew, apt-get)

when dependency is missing in the system. Instead, force user to install it via package manager, or to turn feature purposely OFF by hand.

Spit-off from #23015 as suggested by @guitargeek

This goes totally in-line with what's already done for asimage, zlib, etc.

[github-actions]

Test Results

    23 files      23 suites   3d 18h 53m 34s ⏱️
 3 859 tests  3 858 ✅ 0 💤 1 ❌
79 522 runs  79 520 ✅ 1 💤 1 ❌

For more details on these failures, see this check.

Results for commit 19848e1.

♻️ This comment has been updated with latest results.

[pcanal]

most ROOT builtins already call ROOT_FIND_REQUIRED_DEP which purposely bypasses this flag,

After some usage, I find this change to be indeed more pedantic (useful for system maintainer) but also annoyingly-so for the 'quickly build ROOT on this system for my private usage' (I.e. now installing ROOT on a system that does not already have the required builtin has to go through a step of parsing (by hand or mechanically) the output of cmake to find the --builtin- are that needed ... I find this onerous for a private installation).

so I am not (yet?) convinced that completely removing the feature (auto-turn on) is desirable.

[ferdymercury]

I think AI could do that parsing and -Dbuiltin=On for you to paste on the terminal. One could also improve the printed error messages so that Root already proposes -Dbuiltin1=ON ... In a one liner rather than scattered as now

now installing ROOT on a system that does not already have the required builtin has to go through a step of parsing

Can't you install instead the dependencies via homebrew or apt? So that you don't need to parse anything, just copy paste packages.txt from rootci images?

I think more developer time is spent on maintaining those many code branches (and bugs) than the time spent in writing by hand built-in On.

[pcanal]

Can't you install instead the dependencies via homebrew or apt? So that you don't need to parse anything, just copy paste packages.txt from rootci images?

I am using a system that has neither homebrew nor apt.

I think AI could do that parsing and -Dbuiltin=On for you to paste on the terminal. One could also improve the printed error messages so that Root already proposes -Dbuiltin1=ON ... In a one liner rather than scattered as now

I suspect that would help (albeit in my latest attempt they came in waves (i.e. not all were printed in the first run))

than the time spent in writing by hand built-in On.

This is hard to quantify since this is about end-user-but-I-still-build-ROOT-locally use case.

[silverweed]

now installing ROOT on a system that does not already have the required builtin has to go through a step of parsing (by hand or mechanically) the output of cmake to find the --builtin- are that needed ... I find this onerous for a private installation

I deem this to be the totally-normal process that one should expect whenever one wants to compile a package themselves...

[ferdymercury]

I suspect that would help (albeit in my latest attempt they came in waves (i.e. not all were printed in the first run))

Could you re-check now ? All messages should come all together in one wave, and the last line should be the hotfix that you could copy paste verbatim to have the required builtin_xx = ON flags.

[ferdymercury]

Failures seem unrelated

[pcanal]

I suspect that would help (albeit in my latest attempt they came in waves (i.e. not all were printed in the first run))

Could you re-check now ? All messages should come all together in one wave, and the last line should be the hotfix that you could copy paste verbatim to have the required builtin_xx = ON flags.

I think this is a good idea and we just need to tweak the printout. For me it came out as:

CMake Error at cmake/modules/SearchInstalledSoftware.cmake:286 (message):
  Alternatively, a hotfix would be to add these flags to your CMake call:
  '-Dbuiltin_lz4=ON';'-Dbuiltin_lzma=ON';'-Dbuiltin_zstd=ON';'-Dbuiltin_xxhash=ON';'-Dbuiltin_gif=ON';'-Dbuiltin_jpeg=ON';'-Dbuiltin_png=ON';'-Dbuiltin_tiff=ON';'-Dbuiltin_nlohmannjson=ON';'-Dbuiltin_freetype=ON';'-Dbuiltin_gl2ps=ON';'-Dbuiltin_ftgl=ON';'-Dbuiltin_openssl=ON';'-Dssl=OFF';'-Dbuiltin_civetweb=ON';'-Dbuiltin_vdt=ON';'-Dbuiltin_cfitsio=ON';'-Dbuiltin_xrootd=ON';'-Dbuiltin_tbb=ON';'-Dbuiltin_pcre=ON'
Call Stack (most recent call first):
  CMakeLists.txt:136 (include)

where we just need to ensure the ; are replaced by spaces.

Thanks.

[ferdymercury]

Right... fixed now

[ferdymercury]

Looking green :)

[pcanal]

Yes, very green! Thanks. (Although the 'Checks' link/tab has a stale version of the "Test Results" which shows the (expected) transient failure in roottest-root-io-cpp11Containers-unorderedMap)

[pcanal]

LGTM. Thank!