Repository navigation
docs: record QA/PROD rebuild-workflow parity rule (follow-up to #2917) - #2918
Merged
Merged
Conversation
rebuild-content-qa.yml jumped from the island-manifest step straight to build:qa, with no step to generate the two gitignored CSS build outputs (fundamental-styles-icon.css via build:icon-subset, sap-fundamental.css via build:css). rebuild-content.yml (PROD) has had that step all along, so a clean QA checkout died at head.html:27 (resources.Get on the missing icon CSS) while PROD was unaffected. - Add the 'Build fingerprinted CSS (sap-fundamental + icon subset)' step to the QA workflow, in the same position PROD runs it (before the Hugo build). - Document the two-workflow parity rule + the list of gitignored Hugo build inputs in mta-deployment.md so the drift that caused this doesn't recur.
# Conflicts: # .github/workflows/rebuild-content-qa.yml
jung-thomas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The QA rebuild workflow was missing the
build:icon-subset+build:cssstep that PROD'srebuild-content.ymlhas, so clean QA checkouts died athead.html:27. That workflow fix already landed on DEV via #2917 (fix(ci): regenerate fingerprinted CSS before QA Hugo build).This PR originally carried the same workflow fix; after #2917 merged I merged DEV in and reconciled — the workflow step now matches #2917 exactly (no duplicate). The net change here is doc-only.
Change
docs/developers/operations/mta-deployment.md— new Gotchas subsection recording the root lesson so the drift doesn't recur:/tmp/hugodirectly, notnpm run build:all, so each must list every gitignored-build-output generator step explicitly — and they drift silently because nothing cross-checks them;fundamental-styles-icon.css→build:icon-subset,sap-fundamental.css→build:css,island_manifest.json→build:island-manifest);npm run deployis unaffected (runsbuild:all) but CI rebuild workflows are not — parity is review-time discipline.Complements #2917 (the fix) with the institutional memory of why and how to not repeat it.
🤖 Generated with Claude Code