Repository navigation
fix(display-app): correct Ukrainian number words (was Russian) - #2942
Merged
Merged
Conversation
release 1.41.6: app-space completion fix for reset tutorials
The `ukrainian` number-to-words converter contained Russian vocabulary and grammar throughout (e.g. 752 rendered as "семьсот пятьдесят два"). Replaced with correct Ukrainian (сімсот п'ятдесят два), including proper thousands agreement (одна тисяча / дві тисячі / N тисяч). Reported from the live Community Clubhouse display at TechEd.
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The event-display app's
ukrainiannumber-to-words converter was actually Russian — vocabulary and grammar both. At the live Community Clubhouse display (TechEd),752rendered as СЕМЬСОТ ПЯТЬДЕСЯТ ДВА (Russian) under a label reading "Ukrainian". Reported by Witalij.Now renders correct Ukrainian: сімсот п'ятдесят два.
Changes
app/display-app/src/number-words.ts— rewrote theukrainian()word tables (units, teens, tens, hundreds, zero) and thousands-agreement logic (одна тисяча / дві тисячі / N тисяч). Single file, 11 lines changed.Verification
Ran the converter over 0–5000 spot-check values; all Ukrainian outputs confirmed correct by comparison with standard Ukrainian cardinals. Notably:
сімсот п'ятдесят дваодна тисяча, 2000 →дві тисячі, 5000 →п'ять тисячдев'ятсот дев'яносто дев'ятьNo Russian strings remain in the function. Runtime output verified via
tsx; the onlytscerror is a pre-existingstyle.cssside-effect-import type stub, unrelated to this change.Scope note
Audited the other 8 languages while here. Only Ukrainian was wrong-language. Minor grammar/spacing/spelling nits exist in Arabic (hundreds spelled خمسمية vs خمسمائة, 2000/5000 forms), English/Mandarin (stray comma-space in the thousands connector), and Hebrew (2000 should be אלפיים) — deliberately left out of this PR to keep the live-fix tight. Worth a follow-up issue.
Test plan
752asСІМСОТ П'ЯТДЕСЯТ ДВАwhentheme/language cycles to UkrainiangoalTarget=2000display correctly