fix(tests): honor ClickHouse version in providers - #345
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #345 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 42 42
Lines 862 862
=======================================
Hits 828 828
Misses 34 34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
simPod
changed the title
simPod
changed the title
simPod
force-pushed
the
fix/infection-initial-tests
branch
from
August 13, 2026 09:29
c01d331 to
2fb5718
Compare
simPod
force-pushed
the
fix/infection-initial-tests
branch
from
August 13, 2026 09:30
2fb5718 to
a7dbe7e
Compare
simPod
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Infection runs integration tests against ClickHouse 22.10.
Root Cause
PHPUnit evaluates data providers before its environment bootstrap. The provider read
$_ENV, defaulted to 23.12, and selected cases that ClickHouse 22.10 cannot run.Decision
Read the process environment directly when constructing the ClickHouse version and limit the
Array(IPv6)case to supported ClickHouse versions.Consequences
The integration-test matrix now matches the ClickHouse version configured for the test process.