Skip to content

fix(tests): honor ClickHouse version in providers #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simPod merged 1 commit into from
Aug 13, 2026
+13 −9
Merged

fix(tests): honor ClickHouse version in providers #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/ClickHouseVersion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@

use RuntimeException;

use function assert;
use function explode;
use function is_string;
use function getenv;
use function sprintf;
use function str_pad;
use function strpos;
Expand All @@ -24,8 +23,10 @@
/** @throws RuntimeException */
public static function get(): int
{
$versionString = $_ENV[self::EnvName] ?? '23.12';
assert(is_string($versionString));
$versionString = getenv(self::EnvName);
if ($versionString === false) {
$versionString = '23.12';
}

if (strpos($versionString, '.') === false) {
throw new RuntimeException(sprintf('Specify also a ClickHouse minor version. "%s" given.', $versionString));
Expand Down
13 changes: 8 additions & 5 deletions tests/Param/ParamValueConverterRegistryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,14 @@ public static function providerConvert(): Generator
yield 'UUID' => ['UUID', 'de90cd12-7100-436e-bfb8-f77e4c7a224f', 'de90cd12-7100-436e-bfb8-f77e4c7a224f'];

yield 'Array IPv4' => ['Array(IPv4)', ['192.0.2.1', '198.51.100.1'], "['192.0.2.1','198.51.100.1']"];
yield 'Array IPv6' => [
'Array(IPv6)',
['::ffff:192.0.2.1', '2001:db8::1'],
"['::ffff:192.0.2.1','2001:db8::1']",
];

if (ClickHouseVersion::get() >= self::VersionIntervalJson) {
yield 'Array IPv6' => [
'Array(IPv6)',
['::ffff:192.0.2.1', '2001:db8::1'],
"['::ffff:192.0.2.1','2001:db8::1']",
];
}

yield 'Date' => ['Date', '2023-02-01', '2023-02-01'];
yield 'Date (datetime)' => ['Date', new DateTimeImmutable('2023-02-01'), '2023-02-01'];
Expand Down
Loading