improvement(knip): check entry exports of private packages and delete their dead barrels by waleedlatif1 · Pull Request #8595 · simstudioai/sim

waleedlatif1 · 2026-10-03T07:58:11Z

Summary

check:unused-exports never reported entry exports, so the private workspace packages had no export checking at all — @sim/emcn exports ./*, which made every emcn file an entry.
includeEntryExports is now on by default; the apps (framework entries), the published packages (cli, sim-cli, sim-setup, ts-sdk), db (standalone scripts), and the root opt out. A new private package is checked without opting in.
Every finding this exposed is resolved rather than baselined — the baseline adds nothing:
- dead barrels removed: the @sim/utils and @sim/workflow-persistence root barrels (every caller uses a subpath), unused @sim/workflow-renderer, @sim/desktop-bridge, and @sim/emcn re-exports
- exports used only in their own file lose export (component props interfaces are kept, just not exported)
- unused declarations deleted, e.g. emcn RadarChart, ChipModalPromptBody, 7 unreferenced icons, unused protocol aliases and @sim/utils helpers
- three exports whose consumer knip cannot see carry a @public tag saying why (ChipTimePicker as documented chip-family API, a module generate-docs.ts loads by path, and the check:utils replacement for crypto.randomBytes())

Type of Change

Improvement

Testing

bun run lint, bun run type-check, bun run check:audits (58, incl. check:unused-exports and check:desktop-bridge), docs-manifest:check, block-registry check, root bun run test
Confirmed the @public tag is load-bearing: removing it re-reports the export

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

vercel · 2026-10-03T07:58:14Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Oct 3, 2026 9:02am UTC

greptile-apps · 2026-10-03T08:00:30Z

Confidence Score: 5/5

[Medium risk] Removes unused exports from private packages and updates import paths.

The PR appears safe to merge; no outstanding findings or new actionable issues were identified.

Summary

The PR enables entry-export checking for private packages, removes unused exports and barrels, and updates affected imports. Since the previous review, it also makes unused tool types file-local or deletes them and shrinks the unused-export baseline.

_{Reviews (4) · Last reviewed commit: "chore(knip): shrink the unused-exports b..."}

cubic-dev-ai

All reported issues were addressed across 31 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-10-03T08:26:56Z

@greptile

waleedlatif1 · 2026-10-03T08:26:57Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-03T08:27:03Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 94 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

waleedlatif1 · 2026-10-03T08:46:30Z

@greptile

waleedlatif1 · 2026-10-03T08:46:31Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-03T08:46:37Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 96 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

… their dead barrels - knip.jsonc: includeEntryExports on for every private package except db - delete the bare @sim/utils and @sim/workflow-persistence barrels and their "." exports - drop unused re-exports from the workflow-renderer and desktop-bridge barrels; un-export symbols only used in-file - delete 7 unreferenced emcn icons - baseline the remaining 262 entry-export findings (one-time rule expansion via --update --init)

…export check exposed - Delete exports nothing uses: RadarChart, ChipModalPromptBody, InputOTPSeparator, DropdownMenuGroup/Portal, legacy terminal tool names, and dead types and helpers - Drop `export` from declarations used only in their own file, and remove barrel re-exports no consumer imports - Tag getOAuthClientCapabilityFields and generateRandomBytes `@public`: generate-docs loads the first by file path, and check:utils names the second - Trim the workflow-authz mock to the module's remaining exports - The unused-exports baseline gains no entries and drops one

…y API

…urce panel lost its entry list

…taging

waleedlatif1 · 2026-10-03T09:00:31Z

@greptile

waleedlatif1 · 2026-10-03T09:00:32Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-03T09:00:40Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 96 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

waleedlatif1 requested a review from a team as a code owner October 3, 2026 07:58

vercel Bot deployed to Preview October 3, 2026 08:00 View deployment

greptile-apps Bot reviewed Oct 3, 2026

View reviewed changes

Comment thread scripts/check-unused-exports.baseline.json Outdated

cubic-dev-ai Bot reviewed Oct 3, 2026

View reviewed changes

Comment thread scripts/check-unused-exports.baseline.json Outdated

vercel Bot deployed to Preview October 3, 2026 08:29 View deployment

greptile-apps Bot reviewed Oct 3, 2026

View reviewed changes

Comment thread packages/emcn/src/components/bulk-action-button/bulk-action-button.tsx

cubic-dev-ai Bot reviewed Oct 3, 2026

View reviewed changes

waleedlatif1 force-pushed the improvement/private-package-entry-exports branch from e1f9827 to 74d2b68 Compare October 3, 2026 08:46

vercel Bot deployed to Preview October 3, 2026 08:48 View deployment

cubic-dev-ai Bot reviewed Oct 3, 2026

View reviewed changes

waleedlatif1 added 6 commits October 3, 2026 01:54

fix(emcn): keep ChipTimePicker in the barrel as documented chip-famil…

e8cbe2e

…y API

chore(emcn): export CVA variants only once another module composes them

49e8f91

chore(emcn): delete the PillsRing icon, unused since the generic reso…

b36a479

…urce panel lost its entry list

chore(knip): shrink the unused-exports baseline after rebasing onto s…

6ac3229

…taging

waleedlatif1 force-pushed the improvement/private-package-entry-exports branch from 74d2b68 to 6ac3229 Compare October 3, 2026 09:00

cubic-dev-ai Bot reviewed Oct 3, 2026

View reviewed changes

vercel Bot deployed to Preview October 3, 2026 09:02 View deployment

waleedlatif1 merged commit 1f5001c into staging Oct 3, 2026
36 checks passed

waleedlatif1 deleted the improvement/private-package-entry-exports branch October 3, 2026 09:13

Conversation

waleedlatif1 commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 3, 2026

Uh oh!

waleedlatif1 commented Oct 3, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 3, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 3, 2026

Uh oh!

waleedlatif1 commented Oct 3, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 3, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 3, 2026

Uh oh!

waleedlatif1 commented Oct 3, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 3, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Oct 3, 2026 •

edited

Loading

vercel Bot commented Oct 3, 2026 •

edited

Loading

greptile-apps Bot commented Oct 3, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading