fix(cubejs): scaffold primary keys on join targets too#71
Merged
Conversation
Follow-up to #70: cube requires a primary key on BOTH sides of a join — 'primary key for X is required when join is defined' also fires for the referenced cube (Rental belongsTo Customer ⇒ Customer needs a pk). Add the hidden id-pattern primary-key dimension to every scaffolded cube that has one, not only cubes that own joins. Verified: 3-table Pagila scaffold now compiles and serves Rental/Film/Customer. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #70 — cube requires a primary key on BOTH sides of a join: the compile error also fires for the referenced cube (
Rental belongsTo Customer⇒ Customer needs a pk). Every scaffolded cube with an id-pattern column now gets the hidden primary-key dimension.Verified locally: 3-table Pagila scaffold compiles and serves
Rental/Film/Customer.🤖 Generated with Claude Code