Skip to content

fix(cubejs): scaffold primary keys on join targets too #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acmeguy merged 1 commit into from
Jul 13, 2026
Merged

fix(cubejs): scaffold primary keys on join targets too #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions services/cubejs/src/routes/generateDataSchema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,23 @@ const ensureYamlPrimaryKeys = (files, schema) => {
}
let changed = false;
(doc?.cubes || []).forEach((cube) => {
if (!cube?.joins?.length) return;
// Every scaffolded cube gets a primary key when an id-pattern column
// exists — join SOURCES need it to compile, and join TARGETS need it
// for aggregate correctness ("primary key for 'X' is required when
// join is defined" fires for the referenced cube too).
const dimensions = cube.dimensions || [];
if (dimensions.some((d) => d.primary_key || d.primaryKey)) return;

const tableMatch = /from\s+(?:[\w"]+\.)?"?(\w+)"?/i.exec(cube.sql || "");
const tableName = tableMatch?.[1];
const columns = (tableName && columnsByTable[tableName]) || [];
const joins = cube.joins || [];
const pkColumn =
columns.find((c) => c === "id") ||
columns.find((c) => c === `${tableName}_id`) ||
columns.find((c) => /_id$/.test(c) && cube.joins.every((j) => !(j.sql || "").includes(`{CUBE}.${c}`)));
columns.find(
(c) => /_id$/.test(c) && joins.every((j) => !(j.sql || "").includes(`{CUBE}.${c}`))
);
if (!pkColumn) return;

dimensions.unshift({
Expand Down
Loading