Skip to content

all: simplify promoted field references - #1134

Merged
keegancsmith merged 1 commit into
mainfrom
k/direct-embedded-fields
Aug 14, 2026
Merged

all: simplify promoted field references#1134
keegancsmith merged 1 commit into
mainfrom
k/direct-embedded-fields

Conversation

@keegancsmith

@keegancsmith keegancsmith commented Aug 14, 2026

Copy link
Copy Markdown
Member

Running modernize over the zoekt codebase this is the most common change it does so shipping as its own PR.

Go permits promoted methods and fields to be selected directly, so retaining the embedded type qualification only adds noise. Use direct selectors consistently to make these accesses easier to read without changing behavior.

Amp-Thread-ID: https://ampcode.com/threads/T-019fff44-5b25-709a-a557-5b8daee9cf75
@keegancsmith keegancsmith changed the title refactor/go: simplify promoted field references all: simplify promoted field references Aug 14, 2026
@keegancsmith
keegancsmith marked this pull request as ready for review August 14, 2026 09:19
@keegancsmith
keegancsmith merged commit b0de0bb into main Aug 14, 2026
7 checks passed
@keegancsmith
keegancsmith deleted the k/direct-embedded-fields branch August 14, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants